You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/06/07 14:30:46 UTC

[GitHub] [yunikorn-web] craigcondit commented on pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update

craigcondit commented on PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#issuecomment-1580948889

   > Angular 15 mentions it in the release notes that a tool has to be run it shows slightly different changes than you have made. I did not link that back to the objects we used while migrating. I found it based on your mdc changes: https://material.angular.io/guide/mdc-migration We need to run that tool as the base change, apply the healthcheck, about-menu, about-card and help-menu changes on top of that.
   
   Good catch. Didn't realize there was an automated tool for this. I've updated the PR, also fixed a minor issue with the search box on the apps page where height was wrong and size was way too large to fit on a reasonable-sized window.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org