You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/08/19 12:38:53 UTC
Review Request 13642: Cloudstack-4356: Implicit planner - Added check for
empty host, Skip if no empty host found
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13642/
-----------------------------------------------------------
Review request for cloudstack, Rayees Namathponnan and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Issue 4356: Implicit planner
As mentioned in the issue, added check for finding empty host.
Passed zone id of empty host while creating deployment.
If no empty host is found, test case will skip.
However, deployment of VM still fails with implicit dedication even when empty host is found. Created Issue 4397 for this.
Diffs
-----
test/integration/component/test_implicit_planner.py 854b481
Diff: https://reviews.apache.org/r/13642/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 13642: Cloudstack-4356: Implicit planner - Added check
for empty host, Skip if no empty host found
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13642/#review25347
-----------------------------------------------------------
Ship it!
- Prasanna Santhanam
On Aug. 19, 2013, 12:55 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13642/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 12:55 p.m.)
>
>
> Review request for cloudstack, Rayees Namathponnan and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue 4356: Implicit planner
> As mentioned in the issue, added check for finding empty host.
> Passed zone id of empty host while creating deployment.
>
> If no empty host is found, test case will skip.
>
> However, deployment of VM still fails with implicit dedication even when empty host is found. Created Issue 4397 for this.
>
>
> Diffs
> -----
>
> test/integration/component/test_implicit_planner.py 854b481
>
> Diff: https://reviews.apache.org/r/13642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 13642: Cloudstack-4356: Implicit planner - Added check
for empty host, Skip if no empty host found
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13642/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 12:55 p.m.)
Review request for cloudstack, Rayees Namathponnan and Prasanna Santhanam.
Changes
-------
Added check for any SSVM or routers running on host, as implicit dedication also considers these two too along with user vms while finding an "Empty Host".
Repository: cloudstack-git
Description
-------
Issue 4356: Implicit planner
As mentioned in the issue, added check for finding empty host.
Passed zone id of empty host while creating deployment.
If no empty host is found, test case will skip.
However, deployment of VM still fails with implicit dedication even when empty host is found. Created Issue 4397 for this.
Diffs (updated)
-----
test/integration/component/test_implicit_planner.py 854b481
Diff: https://reviews.apache.org/r/13642/diff/
Testing
-------
Thanks,
Gaurav Aradhye