You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2026/09/03 12:36:54 UTC
(myfaces-tobago) branch main updated: build(deps): checkstyle
This is an automated email from the ASF dual-hosted git repository.
henningn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
The following commit(s) were added to refs/heads/main by this push:
new 69dda617dc build(deps): checkstyle
69dda617dc is described below
commit 69dda617dc49bd913ccebaa9da71fe0f230ba2f3
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Thu Sep 3 14:12:07 2026 +0200
build(deps): checkstyle
* fix checkstyle issues
---
pom.xml | 2 +-
.../org/apache/myfaces/tobago/component/SupportsAutocomplete.java | 2 +-
.../myfaces/tobago/internal/component/AbstractUISelectBoolean.java | 2 +-
.../internal/renderkit/renderer/DecorationPositionRendererBase.java | 4 ++--
.../myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java | 2 +-
.../java/org/apache/myfaces/tobago/example/demo/EventController.java | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/pom.xml b/pom.xml
index e4dd6a9980..8df339296c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -374,7 +374,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>14.0.0</version>
+ <version>14.1.0</version>
</dependency>
</dependencies>
</plugin>
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/component/SupportsAutocomplete.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/component/SupportsAutocomplete.java
index bbfce0b73e..58bb742143 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/component/SupportsAutocomplete.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/component/SupportsAutocomplete.java
@@ -28,7 +28,7 @@ default String getAutocompleteString() {
if (object == null) {
return null;
} else if (object instanceof Boolean) {
- return ((Boolean) object) ? "on" : "off";
+ return (Boolean) object ? "on" : "off";
} else if (object instanceof String) {
final String string = (String) object;
if (string.equals("true")) {
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
index 88a5890410..84832233b0 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
@@ -57,7 +57,7 @@ public boolean isSelected() {
@Override
protected void validateValue(final FacesContext facesContext, final Object convertedValue) {
if (isRequired()) {
- if (convertedValue instanceof Boolean && !((Boolean) convertedValue)
+ if (convertedValue instanceof Boolean && !(Boolean) convertedValue
// String: e.g. if there is no ValueExpression
|| convertedValue instanceof String && !Boolean.parseBoolean((String) convertedValue)) {
final String requiredMessage = getRequiredMessage();
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DecorationPositionRendererBase.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DecorationPositionRendererBase.java
index b182e03964..d4c086a699 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DecorationPositionRendererBase.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DecorationPositionRendererBase.java
@@ -81,7 +81,7 @@ public void encodeBeginMessageField(final FacesContext facesContext, final T com
final TobagoResponseWriter writer = getResponseWriter(facesContext);
final Integer tabIndex = component instanceof AbstractUIInput ? ((AbstractUIInput) component).getTabIndex() : null;
final SupportsDecorationPosition supportsDecorationPosition = component instanceof SupportsDecorationPosition
- ? ((SupportsDecorationPosition) component) : null;
+ ? (SupportsDecorationPosition) component : null;
final DecorationPosition helpPosition = supportsDecorationPosition != null
? supportsDecorationPosition.getHelpPosition() : DecorationPosition.none;
@@ -139,7 +139,7 @@ public void encodeEndMessageField(final FacesContext facesContext, final T compo
final TobagoResponseWriter writer = getResponseWriter(facesContext);
final Integer tabIndex = component instanceof AbstractUIInput ? ((AbstractUIInput) component).getTabIndex() : null;
final SupportsDecorationPosition supportsDecorationPosition = component instanceof SupportsDecorationPosition
- ? ((SupportsDecorationPosition) component) : null;
+ ? (SupportsDecorationPosition) component : null;
encodeEndField(facesContext, component);
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
index ef6e2a6da2..2b791a9b24 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
@@ -594,7 +594,7 @@ private void encodeTableBody(
}
final Object rowRendered = sheet.getAttributes().get("rowRendered");
- if (rowRendered instanceof Boolean && !((Boolean) rowRendered)) {
+ if (rowRendered instanceof Boolean && !(Boolean) rowRendered) {
continue;
}
diff --git a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
index d41a8f1665..d339773710 100644
--- a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
+++ b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
@@ -192,7 +192,7 @@ public String getEventName() {
public void selectComponent(final ActionEvent actionEvent) {
reset();
final UIData data = ComponentUtils.findAncestor(actionEvent.getComponent(), UIData.class);
- selectedComponent = data != null ? ((EventsOnComponent) data.getRowData()) : null;
+ selectedComponent = data != null ? (EventsOnComponent) data.getRowData() : null;
eventName = actionEvent.getComponent().getAttributes().get("eventName").toString();
}