You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by br...@apache.org on 2009/02/06 11:43:19 UTC
svn commit: r741519 - in
/maven/core-integration-testing/trunk/core-it-suite/src/test:
java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java
resources/mng-3719/ resources/mng-3719/pom.xml
Author: brett
Date: Fri Feb 6 10:43:18 2009
New Revision: 741519
URL: http://svn.apache.org/viewvc?rev=741519&view=rev
Log:
[MNG-3719] restore ordering of plugin executions
Added:
maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java (with props)
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml (with props)
Added: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java?rev=741519&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java Fri Feb 6 10:43:18 2009
@@ -0,0 +1,80 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.util.List;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-3719">MNG-3719</a>.
+ *
+ * @author Brett Porter
+ * @version $Id: MavenITmng4016PrefixedPropertyInterpolationTest.java 739321 2009-01-30 16:09:55Z bentmann $
+ */
+public class MavenITmng3719PomExecutionOrderingTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng3719PomExecutionOrderingTest()
+ {
+ super( "[2.0.11,2.1.0-M1),[2.1.0-M2,)" );
+ }
+
+ /**
+ * Test that 3 executions are run in the correct order.
+ */
+ public void testitMNG3719()
+ throws Exception
+ {
+ File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-3719" );
+
+ Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+ verifier.setAutoclean( false );
+ verifier.deleteDirectory( "target" );
+ verifier.executeGoal( "validate" );
+ verifier.verifyErrorFreeLog();
+ verifier.resetStreams();
+
+ Pattern pattern = Pattern.compile( ".*\\{execution: step ([0-9])\\}.*" );
+
+ int[] stepLines = new int[3];
+ List content = verifier.loadFile( verifier.getBasedir(), verifier.getLogFileName(), false );
+ for ( int i = 0; i < content.size(); i++ )
+ {
+ String line = (String) content.get( i );
+
+ Matcher m = pattern.matcher( line );
+ if ( m.matches() )
+ {
+ int step = Integer.valueOf( m.group( 1 ) ).intValue();
+ stepLines[step - 1] = i + 1;
+ }
+ }
+
+ // check order - note it is not in sequence as the plugin definitions are merged
+ assertTrue( "Step 1 should be found", stepLines[0] > 0 );
+ assertTrue( "Step 3 should be second", stepLines[0] < stepLines[2] );
+ assertTrue( "Step 2 should be third", stepLines[2] < stepLines[1] );
+ }
+}
Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3719PomExecutionOrderingTest.java
------------------------------------------------------------------------------
svn:eol-style = native
Added: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml?rev=741519&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml Fri Feb 6 10:43:18 2009
@@ -0,0 +1,97 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.mng3719</groupId>
+ <artifactId>test</artifactId>
+ <version>0.1</version>
+ <packaging>pom</packaging>
+
+ <name>Maven Integration Test :: MNG-3719</name>
+ <description>
+ Test the plugins are executeed in the order given in the POM.
+ </description>
+
+ <properties>
+ <foo>bar</foo>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.its.plugins</groupId>
+ <artifactId>maven-it-plugin-file</artifactId>
+ <version>2.1-SNAPSHOT</version>
+ <executions>
+ <execution>
+ <id>step 1</id>
+ <phase>validate</phase>
+ <goals>
+ <goal>file</goal>
+ </goals>
+ <configuration>
+ <pathname>target/model.properties</pathname>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.its.plugins</groupId>
+ <artifactId>maven-it-plugin-expression</artifactId>
+ <version>2.1-SNAPSHOT</version>
+ <executions>
+ <execution>
+ <id>step 2</id>
+ <phase>validate</phase>
+ <goals>
+ <goal>eval</goal>
+ </goals>
+ <configuration>
+ <outputFile>target/model.properties</outputFile>
+ <expressions>
+ <expression>project/properties</expression>
+ </expressions>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.its.plugins</groupId>
+ <artifactId>maven-it-plugin-file</artifactId>
+ <version>2.1-SNAPSHOT</version>
+ <executions>
+ <execution>
+ <id>step 3</id>
+ <phase>validate</phase>
+ <goals>
+ <goal>file</goal>
+ </goals>
+ <configuration>
+ <pathname>target/model.properties</pathname>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+</project>
Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3719/pom.xml
------------------------------------------------------------------------------
svn:eol-style = native