You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/03 23:40:16 UTC

[GitHub] [flink] mans2singh opened a new pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

mans2singh opened a new pull request #17408:
URL: https://github.com/apache/flink/pull/17408


   
   ## What is the purpose of the change
   
   * The table docs does not show back ticks in the select statement for identifiers with space
   
   ## Brief change log
   
   * Corrected markup to show back-ticks
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no 
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no 
     - The S3 file system connector: no 
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-938521492


   Thanks @wuchong @leonardBang.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-933051830


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6a4ed39916ee7e10d50f734991368cf690d88889 (Sun Oct 03 23:42:42 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24442).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #17408:
URL: https://github.com/apache/flink/pull/17408


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-933060740


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24729",
       "triggerID" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a4ed39916ee7e10d50f734991368cf690d88889 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24729) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-933060740


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24729",
       "triggerID" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a4ed39916ee7e10d50f734991368cf690d88889 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24729) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-933060740


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a4ed39916ee7e10d50f734991368cf690d88889",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a4ed39916ee7e10d50f734991368cf690d88889 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #17408: [FLINK-24442][table][docs] - Corrected markup to show back ticks

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #17408:
URL: https://github.com/apache/flink/pull/17408#issuecomment-938235770


   @leonardBang @wuchong - Can you please review this PR ?  Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org