[GitHub] [iceberg] stevenzwu commented on pull request #2305: Flink: FLIP-27 source split and reader

[GitBox <gi...@apache.org>]

stevenzwu commented on pull request #2305:
URL: https://github.com/apache/iceberg/pull/2305#issuecomment-872291815


   @openinx @sundargates @holdenk @tweise Now this sub PR is ready for review. 
   
   I have changed the code not to extend from FileSourceSplit and BulkFormat, as we are aligned that Iceberg source reader probably can't reuse the vectorized readers from Flink. The main reason is that future Iceberg V2 format supports deletes, which is a concept applicable to Iceberg (not the raw file formats like Orc, Parquet etc.). Hence we can't reuse Flink's vectorized readers with delete filters.
   
   I also moved some unrelated refactoring out of this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org