You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/21 01:56:21 UTC
[GitHub] [spark] kiszk commented on issue #24636: [SPARK-27684][SQL] Avoid
conversion overhead for primitive types
kiszk commented on issue #24636: [SPARK-27684][SQL] Avoid conversion overhead for primitive types
URL: https://github.com/apache/spark/pull/24636#issuecomment-494210096
Good PR. I will review this carefully.
One minor comment: I like performance improvements using `Benchmark` class. On the other hand, I am not convinced by the first experiment in the description. Since there is no warm-up time. it may include the execution time on interpreter instead of native code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org