You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "yu199195 (via GitHub)" <gi...@apache.org> on 2023/07/13 04:14:33 UTC
[GitHub] [shenyu] yu199195 opened a new pull request, #4838: refactor shenyu reigstry
yu199195 opened a new pull request, #4838:
URL: https://github.com/apache/shenyu/pull/4838
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4838: refactor shenyu reigstry
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #4838:
URL: https://github.com/apache/shenyu/pull/4838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4838: refactor shenyu reigstry
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4838:
URL: https://github.com/apache/shenyu/pull/4838#issuecomment-1633857982
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4838](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0f2dd50) into [master](https://app.codecov.io/gh/apache/shenyu/commit/1fff6b3277dde58d0e958223122d2df63346673d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1fff6b3) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0f2dd50 differs from pull request most recent head 981dff3. Consider uploading reports for the commit 981dff3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4838 +/- ##
============================================
- Coverage 64.58% 64.44% -0.14%
+ Complexity 8180 8167 -13
============================================
Files 1147 1147
Lines 33805 33805
Branches 3016 3012 -4
============================================
- Hits 21832 21785 -47
- Misses 10252 10294 +42
- Partials 1721 1726 +5
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...istry/consul/ConsulInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS9jb25zdWwvQ29uc3VsSW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `34.17% <ø> (ø)` | |
| [...rg/apache/shenyu/registry/consul/TtlScheduler.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS9jb25zdWwvVHRsU2NoZWR1bGVyLmphdmE=) | `3.84% <ø> (ø)` | |
| [.../core/ShenyuInstanceRegisterRepositoryFactory.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0cnkvY29yZS9TaGVueXVJbnN0YW5jZVJlZ2lzdGVyUmVwb3NpdG9yeUZhY3RvcnkuamF2YQ==) | `42.85% <ø> (ø)` | |
| [...va/org/apache/shenyu/registry/etcd/EtcdClient.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0cnkvZXRjZC9FdGNkQ2xpZW50LmphdmE=) | `68.29% <ø> (ø)` | |
| [.../registry/etcd/EtcdInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0cnkvZXRjZC9FdGNkSW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `65.11% <ø> (ø)` | |
| [...istry/eureka/EurekaInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1ldXJla2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS9ldXJla2EvRXVyZWthSW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `65.51% <ø> (ø)` | |
| [...egistry/nacos/NacosInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3JlZ2lzdHJ5L25hY29zL05hY29zSW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `49.01% <ø> (ø)` | |
| [...che/shenyu/registry/zookeeper/ZookeeperClient.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyQ2xpZW50LmphdmE=) | `86.41% <ø> (ø)` | |
| [...che/shenyu/registry/zookeeper/ZookeeperConfig.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | |
| [...zookeeper/ZookeeperInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVySW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `83.07% <ø> (ø)` | |
| ... and [2 more](https://app.codecov.io/gh/apache/shenyu/pull/4838?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4838/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org