You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/30 00:30:09 UTC

[GitHub] [incubator-seatunnel] TaoZex opened a new pull request, #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

TaoZex opened a new pull request, #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   The command line generated by SparkStarter is redundant.
   use config:
   ![config](https://user-images.githubusercontent.com/45089228/198857129-3b6cc9f0-8633-46a1-a41c-dde871798811.png)
   before:
   ![before](https://user-images.githubusercontent.com/45089228/198857409-485f4023-8561-4891-af49-83f2f5e12a66.png)
   after:
   ![after](https://user-images.githubusercontent.com/45089228/198857143-fda35d51-1776-41f3-93a8-0afdff514e9c.png)
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231#issuecomment-1296468687

   Did you have tested? From reading the code, I found that you are removing the above parameter, not the below. The parameters above are for spark, and the parameters below are for seatunnel.
   ![image](https://user-images.githubusercontent.com/32387433/198920557-386f1b25-fac4-4655-8018-f12ac66a418c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231#issuecomment-1296498290

   > Did you have tested? From reading the code, I found that you are removing the above parameter, not the below. The parameters above are for spark, and the parameters below are for seatunnel. ![image](https://user-images.githubusercontent.com/32387433/198920557-386f1b25-fac4-4655-8018-f12ac66a418c.png)
   
   +1, please do the integration test. CC @TaoZex 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231#issuecomment-1296510550

   > > Did you have tested? From reading the code, I found that you are removing the above parameter, not the below. The parameters above are for spark, and the parameters below are for seatunnel. ![image](https://user-images.githubusercontent.com/32387433/198920557-386f1b25-fac4-4655-8018-f12ac66a418c.png)
   > 
   > +1, please do the integration test. CC @TaoZex
   
   Thanks for the review.This image is the first submission of the code. Next, I will do the integration test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231#issuecomment-1319962785

   @CalvinKirs @Hisoka-X PTAL
   
   The command line generated by SparkStarter is redundant.
   
   use config:
   ![d7f34e9afd5123c56443f48bc26cc83](https://user-images.githubusercontent.com/45089228/202710521-1de83a64-9a4a-4875-b74d-e7d42f8ab2f0.png)
   
   ![1cdade20f522243f294d98da2efa995](https://user-images.githubusercontent.com/45089228/202710561-0fbd5d77-2919-4628-9345-98aff3029b3f.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TaoZex closed pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
TaoZex closed pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter
URL: https://github.com/apache/incubator-seatunnel/pull/3231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TaoZex closed pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

Posted by GitBox <gi...@apache.org>.
TaoZex closed pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter
URL: https://github.com/apache/incubator-seatunnel/pull/3231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org