You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/29 12:18:18 UTC

[GitHub] [flink] TisonKun commented on issue #7809: [DO NOT MERGE][FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…

TisonKun commented on issue #7809: [DO NOT MERGE][FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#issuecomment-487557054
 
 
   @azagrebin 
   
   `SimpleSlotProvider` based on `SimpleSlot` which is a legacy resource manage concept. We still need to remove `SimpleSlot` as part of FLINK-10392.
   
   I'd like to close this pr but remain the issue because of my inactive in following days. About the naming comments, I agree with `TestingSlotContext` and `TestingSlotProvider` in test package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services