[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #254: Added initial changes for skipResoultion bug

[GitBox <gi...@apache.org>]

jathanasiou commented on a change in pull request #254:
URL: https://github.com/apache/brooklyn-ui/pull/254#discussion_r673170951



##########
File path: ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js
##########
@@ -63,32 +63,41 @@ export function summaryController($scope, $state, $stateParams, $q, $http, brSna
         vm.error.entity = 'Cannot load entity with ID: ' + entityId;
     });
 
-    entityApi.entityConfigState(applicationId, entityId).then((response)=> {
-        vm.config = response.data;
-        vm.error.config = undefined;
-        observers.push(response.subscribe((response)=> {
-            vm.config = response.data;
-            vm.error.config = undefined;
-        }));
-    }).catch((error)=> {
-        vm.error.config = 'Cannot load configuration for entity with ID: ' + entityId;
-    });
-
     vm.configResolved = false;
 
     vm.refreshConfig = (initialSubscription) => {
-        entityApi.entityConfigInfo(applicationId, entityId, !vm.configResolved).then((response) => {
-            vm.configInfo = response.data;
-            vm.error.config = undefined;
+        entityApi.entityConfigState(applicationId, entityId, {
+                params: {
+                    suppressSecrets: true,
+                    skipResolution: !vm.configResolved,
+                },
+                paramSerializer: (params) => {

Review comment:
       This could be:
   
   ```
   paramSerializer: (params) => $httpParamSerializer({
       ...params,
       skipResolution: !vm.configResolved
   });
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org