You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/02 11:39:11 UTC
[GitHub] [incubator-yunikorn-core] HuangTing-Yao opened a new pull request #164: [YUNIKORN-187] Scheduler.processNodeEvent logs wrong messages on cast failure
HuangTing-Yao opened a new pull request #164:
URL: https://github.com/apache/incubator-yunikorn-core/pull/164
fix error log which in `processNodeEvent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov-commenter commented on pull request #164: [YUNIKORN-187] Scheduler.processNodeEvent logs wrong messages on cast failure
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #164:
URL: https://github.com/apache/incubator-yunikorn-core/pull/164#issuecomment-637506964
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=h1) Report
> Merging [#164](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dd1561fb33bfcbb68f44e0d9f934f58455ebf77f&el=desc) will **not change** coverage.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 62 62
Lines 6179 6179
=======================================
Hits 3627 3627
Misses 2411 2411
Partials 141 141
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=footer). Last update [dd1561f...3f3a260](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/164?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #164: [YUNIKORN-187] Scheduler.processNodeEvent logs wrong messages on cast failure
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #164:
URL: https://github.com/apache/incubator-yunikorn-core/pull/164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #164: [YUNIKORN-187] Scheduler.processNodeEvent logs wrong messages on cast failure
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #164:
URL: https://github.com/apache/incubator-yunikorn-core/pull/164#issuecomment-637611009
Hey @HuangTing-Yao,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/693809081">View build log</a>
###### TravisBuddy Request Identifier: 8a59a150-a4e4-11ea-af7d-f32b9e1b312f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org