You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/05/07 23:03:30 UTC
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13276
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
This test fixes CatalogTest, FrontendTest, CatalogObjectTofromThriftTest
by breaking some tests into the ones which are not expected to work on
Hive-3 and then skipping it. It does this by adding a util method in
TestUtils which returns if the environment variable
IMPALA_HIVE_MAJOR_VERSION is >= 3. If this condition is true, it skips
certain tests which use hive_idx_tbl (not supported in data-load against
Hive-3). If it is less than 3 the tests are not skipped so we keep the
test coverage on Hive-2 setups.
Also, fixes the TestCaseLoaderTest which instantiates a embedded HMS
instance. This requires some configuration changes for the embedded
standalone mode as well as adding datanucleus JDO as a test dependency.
Additionally, this patch also fixes test_show_create_table which was
failing on Hive-3 setups due to the additional parameter
bucketing_version available from Hive-3.
Testing Done:
1. Ran the tests when mini-cluster is deployed with USE_CDP_HIVE=true
and made sure that the tests work (or are skipped as expected)
2. Ran the same tests with USE_CDP_HIVE=false to make sure they still
work against HMS-2
Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
---
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
M tests/metadata/test_show_create_table.py
7 files changed, 69 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13276/1
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3117/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 May 2019 23:34:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/3176/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 19:46:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Found some nitpicks, but otherwise it makes perfect sense to me.
http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
File fe/src/test/java/org/apache/impala/testutil/TestUtils.java:
http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@392
PS2, Line 392: isHive3Supported
nit: I think it's not the best name for the intent. "Hive3 is supported" doesn't mean that we don't support Hive2 and we are not running against Hive2.
Maybe just name it getHiveMajorVersion() and return the parsed integer, and in the tests you could just use 'assumeTrue(..., getHiveMajorVersion() == 2)';
http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py@38
PS2, Line 38: "last_modified_time", "numFilesErasureCoded", "bucketing_version"]
nit: too long line
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 15:00:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 May 2019 17:04:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4234/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 May 2019 10:38:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 21:29:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
This test fixes CatalogTest, FrontendTest, CatalogObjectTofromThriftTest
by breaking some tests into the ones which are not expected to work on
Hive-3 and then skipping it. It does this by adding a util method in
TestUtils which returns if the environment variable
IMPALA_HIVE_MAJOR_VERSION is >= 3. If this condition is true, it skips
certain tests which use hive_idx_tbl (not supported in data-load against
Hive-3). If it is less than 3 the tests are not skipped so we keep the
test coverage on Hive-2 setups.
Also, fixes the TestCaseLoaderTest which instantiates a embedded HMS
instance. This requires some configuration changes for the embedded
standalone mode as well as adding datanucleus JDO as a test dependency.
Additionally, this patch also fixes test_show_create_table which was
failing on Hive-3 setups due to the additional parameter
bucketing_version available from Hive-3.
Testing Done:
1. Ran the tests when mini-cluster is deployed with USE_CDP_HIVE=true
and made sure that the tests work (or are skipped as expected)
2. Ran the same tests with USE_CDP_HIVE=false to make sure they still
work against HMS-2
Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
---
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
M tests/metadata/test_show_create_table.py
7 files changed, 69 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13276/5
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 May 2019 16:14:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
This test fixes CatalogTest, FrontendTest, CatalogObjectTofromThriftTest
by breaking some tests into the ones which are not expected to work on
Hive-3 and then skipping it. It does this by adding a util method in
TestUtils which returns if the environment variable
IMPALA_HIVE_MAJOR_VERSION is >= 3. If this condition is true, it skips
certain tests which use hive_idx_tbl (not supported in data-load against
Hive-3). If it is less than 3 the tests are not skipped so we keep the
test coverage on Hive-2 setups.
Also, fixes the TestCaseLoaderTest which instantiates a embedded HMS
instance. This requires some configuration changes for the embedded
standalone mode as well as adding datanucleus JDO as a test dependency.
Additionally, this patch also fixes test_show_create_table which was
failing on Hive-3 setups due to the additional parameter
bucketing_version available from Hive-3.
Testing Done:
1. Ran the tests when mini-cluster is deployed with USE_CDP_HIVE=true
and made sure that the tests work (or are skipped as expected)
2. Ran the same tests with USE_CDP_HIVE=false to make sure they still
work against HMS-2
Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Reviewed-on: http://gerrit.cloudera.org:8080/13276
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
M tests/metadata/test_show_create_table.py
7 files changed, 69 insertions(+), 9 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
This test fixes CatalogTest, FrontendTest, CatalogObjectTofromThriftTest
by breaking some tests into the ones which are not expected to work on
Hive-3 and then skipping it. It does this by adding a util method in
TestUtils which returns if the environment variable
IMPALA_HIVE_MAJOR_VERSION is >= 3. If this condition is true, it skips
certain tests which use hive_idx_tbl (not supported in data-load against
Hive-3). If it is less than 3 the tests are not skipped so we keep the
test coverage on Hive-2 setups.
Also, fixes the TestCaseLoaderTest which instantiates a embedded HMS
instance. This requires some configuration changes for the embedded
standalone mode as well as adding datanucleus JDO as a test dependency.
Additionally, this patch also fixes test_show_create_table which was
failing on Hive-3 setups due to the additional parameter
bucketing_version available from Hive-3.
Testing Done:
1. Ran the tests when mini-cluster is deployed with USE_CDP_HIVE=true
and made sure that the tests work (or are skipped as expected)
2. Ran the same tests with USE_CDP_HIVE=false to make sure they still
work against HMS-2
Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
---
M fe/pom.xml
M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
M tests/metadata/test_show_create_table.py
7 files changed, 69 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13276/6
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13276/1/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/13276/1/tests/metadata/test_show_create_table.py@38
PS1, Line 38: n
flake8: E501 line too long (93 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 May 2019 23:04:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 May 2019 10:37:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
File fe/src/test/java/org/apache/impala/testutil/TestUtils.java:
http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@392
PS2, Line 392: isHive3Supported
> nit: I think it's not the best name for the intent. "Hive3 is supported" do
Done
http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py@38
PS2, Line 38: "last_modified_time", "numFilesErasureCoded", "bucketing_version"]
> nit: too long line
Done
--
To view, visit http://gerrit.cloudera.org:8080/13276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c
Gerrit-Change-Number: 13276
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 18:42:47 +0000
Gerrit-HasComments: Yes