You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/23 23:59:00 UTC

[jira] [Commented] (IMPALA-8696) Cmake dependencies for container build do not work correctly

    [ https://issues.apache.org/jira/browse/IMPALA-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891481#comment-16891481 ] 

ASF subversion and git services commented on IMPALA-8696:
---------------------------------------------------------

Commit f689daef7f140fb2e227ee96218f31076b5ba257 in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f689dae ]

IMPALA-8622,IMPALA-8696: fix docker dependencies, add image list

Adds a plain-text space-separated image list in
docker/docker-images.txt. This is generated based on the images built by
CMake, so is kept in sync with images added to or removed from the
CMake file.

Duplicated logic per image is removed - instead there is a helper
function that is called for each daemon image to be built.

Rips out the timestamp mechanism that was intended to avoid unnecessary
container rebuilds, but has turned out to be brittle. Instead the
containers are rebuilt each time the rule is invoked.

This moves some subdirectories so that the image tag matches the
subdirectory, to simplify the build scripts.

Change-Id: I4d8e215e9b07c6491faa4751969a30f0ed373fe3
Reviewed-on: http://gerrit.cloudera.org:8080/13899
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>


> Cmake dependencies for container build do not work correctly
> ------------------------------------------------------------
>
>                 Key: IMPALA-8696
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8696
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Infrastructure
>    Affects Versions: Impala 3.3.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> I've noticed in many cases that containers are not reliably rebuilt when inputs change, e.g. if the binaries are rebuilt. Investigate and fix this, it's a major development headache.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org