[jira] [Commented] (ZOOKEEPER-2012) HBase client hangs after client-side OOM

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098521#comment-14098521 ] 

Hadoop QA commented on ZOOKEEPER-2012:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12662037/ZOOKEEPER-2012-trunk.patch
  against trunk revision 1617921.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2283//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2283//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2283//console

This message is automatically generated.

> HBase client hangs after client-side OOM
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2012
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2012
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Qiang Tian
>            Priority: Minor
>         Attachments: ZOOKEEPER-2012-trunk.patch
>
>
> please see http://apache-hbase.679495.n3.nabble.com/HBase-client-hangs-after-client-side-OOM-td4062675.html.
> it looks the send thread caught the error successfully, as it is finally running fine.. but the cleanup fail to notify the main thread...so I suspect it is a very small timing hole that the packet is not on the 2 queues at the same time..it looks it could happen in the latest code ClientCnxnSocketNIO#doIO as well..
> potential fixes:
> 1)add timeout during wait
> 2)try/catch for the possible timing hole:
> {code}
>                   if (!p.bb.hasRemaining()) {
>                         sentCount++;
>                         outgoingQueue.removeFirstOccurrence(p);
>                         if (p.requestHeader != null
>                                 && p.requestHeader.getType() != OpCode.ping
>                                 && p.requestHeader.getType() != OpCode.auth) {
>                             synchronized (pendingQueue) {
>                                 pendingQueue.add(p);
>                             }
>                         }
>                     }
> {code}
> thoughts?
> thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)