You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:03:49 UTC

[GitHub] [kafka] cadonna commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

cadonna commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906227809


   @guozhangwang What do you mean exactly by "this would require us to add another private function like handleStreamsUncaughtException(StreamThreadExceptionResponse)"? 
   Wouldn't it suffice to check the `throwable` variable in `KafkaStreams#handleStreamsUncaughtException()` before line 500 where the user-specified exception handler is executed?
   BTW, I agree with you that we should shutdown the Streams client instead of just killing a stream thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org