You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/05/17 19:52:43 UTC
[jira] Created: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Modifications introduced by HDFS-1150 are breaking aspect's bindings
--------------------------------------------------------------------
Key: HDFS-1157
URL: https://issues.apache.org/jira/browse/HDFS-1157
Project: Hadoop HDFS
Issue Type: Sub-task
Components: test
Affects Versions: 0.20.3
Reporter: Konstantin Boudnik
Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900584#action_12900584 ]
Hairong Kuang commented on HDFS-1157:
-------------------------------------
Cos, Hudson does not work. Since this is a compilation bug, could you please just go ahead and commit it?
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Per Hairong request and considering that this patch has been already verified in y20 release as working I have just committed it to unblock further HDFS development in trunk.
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899523#action_12899523 ]
Kan Zhang commented on HDFS-1157:
---------------------------------
I've seen other AspectJ related test failures, many due to the same reason (method signatures got changed without changing the AspectJ matching logic). Do AspectJ based tests get run on Hudson (or required to pass)?
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900611#action_12900611 ]
Hudson commented on HDFS-1157:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #370 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/])
HDFS-1157. Modifications introduced by HDFS-1150 are breaking aspect's bindings. Contributed by Konstantin Boudnik
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Affects Version/s: 0.22.0
(was: 0.20.3)
Like HDFS-1150 it affects only 0.22
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Tags: herriot
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899533#action_12899533 ]
Konstantin Boudnik commented on HDFS-1157:
------------------------------------------
bq. I've seen other AspectJ related test failures, many due to the same reason (method signatures got changed without changing the AspectJ matching logic). Do AspectJ based tests get run on Hudson (or required to pass)?
I believe you have confused this for fault injection tests. The latter are executed as a part of secondary build, but not the patch build. To prevent braking of the bindings between the code and test framework code (Herriot) I have HADOOP-6786 which still pending {{test-patch}} verification. That JIRA will include the guarantees that a patch doesn't break existing bindings for the test framework.
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Attachment: hdfs-1157.patch
Patch to address the problem.
It can't be verified until HDFS-1150 is committed to the trunk
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Status: Patch Available (was: Open)
Although, test-patch doesn't verify instrumented build's binding (pending HADOOP-6786) I'll submit this for the sake of the process.
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1157:
------------------------------
Hadoop Flags: [Reviewed]
Looks reasonable. +1 pending Hudson (assuming he showed up today...).
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-1157:
----------------------------------------
Assignee: Konstantin Boudnik
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-1157:
-------------------------------------
Parent: (was: HDFS-1134)
Issue Type: Bug (was: Sub-task)
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1157) Modifications introduced by HDFS-1150
are breaking aspect's bindings
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899515#action_12899515 ]
Konstantin Boudnik commented on HDFS-1157:
------------------------------------------
I have verified that the patch works for current HDFS trunk despite that HDFS-1150's patch for trunk was a little different than for y20. So, the patch is still valid.
The reason for the modification is as follows: the call to the original constructor with two parameters has been replaced with call to the new one
{noformat}
return new DataNode(conf, dirs, resources);
{noformat}
While this is a totally compatible change from the Java perspective, one of Herriot aspects was bound to the 'call to the constructor with 2 params' and has been broken as the result of the change
> Modifications introduced by HDFS-1150 are breaking aspect's bindings
> --------------------------------------------------------------------
>
> Key: HDFS-1157
> URL: https://issues.apache.org/jira/browse/HDFS-1157
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: hdfs-1157.patch
>
>
> Modifications introduced by HDFS-1150 to DataNode class brakes the binding of some of Herriot (test framework) bindings. This JIRA is to track the fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.