You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/11 08:00:36 UTC
[GitHub] [hudi] hddong opened a new pull request #1946: [HUDI-1176]Support log4j2 config
hddong opened a new pull request #1946:
URL: https://github.com/apache/hudi/pull/1946
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Now in some modules(like cli, utilities) use log4j2, and it cannot correct load config file with `ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console`.*
## Brief change log
*(for example:)*
- *Support log4j2 config*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (04ac800) into [master](https://codecov.io/gh/apache/hudi/commit/43a0776c7c88a5f7beac6c8853db7e341810635a?el=desc) (43a0776) will **decrease** coverage by `41.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
- Coverage 51.14% 9.69% -41.46%
+ Complexity 3215 48 -3167
============================================
Files 438 53 -385
Lines 20041 1929 -18112
Branches 2064 230 -1834
============================================
- Hits 10250 187 -10063
+ Misses 8946 1729 -7217
+ Partials 845 13 -832
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `9.69% <ø> (-59.78%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/hudi/utilities/HoodieClusteringJob.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZUNsdXN0ZXJpbmdKb2IuamF2YQ==) | `0.00% <ø> (-65.22%)` | `0.00 <0.00> (-9.00)` | |
| [.../apache/hudi/utilities/HoodieSnapshotExporter.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90RXhwb3J0ZXIuamF2YQ==) | `83.62% <ø> (-5.18%)` | `28.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/utilities/UtilHelpers.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL1V0aWxIZWxwZXJzLmphdmE=) | `34.30% <ø> (-31.40%)` | `11.00 <0.00> (-21.00)` | |
| [...callback/kafka/HoodieWriteCommitKafkaCallback.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2NhbGxiYWNrL2thZmthL0hvb2RpZVdyaXRlQ29tbWl0S2Fma2FDYWxsYmFjay5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...udi/utilities/deltastreamer/BootstrapExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvQm9vdHN0cmFwRXhlY3V0b3IuamF2YQ==) | `0.00% <ø> (-79.55%)` | `0.00 <0.00> (-6.00)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `0.00% <ø> (-70.00%)` | `0.00 <0.00> (-50.00)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `0.00% <ø> (-68.73%)` | `0.00 <0.00> (-18.00)` | |
| [...s/deltastreamer/HoodieMultiTableDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllTXVsdGlUYWJsZURlbHRhU3RyZWFtZXIuamF2YQ==) | `0.00% <ø> (-78.40%)` | `0.00 <0.00> (-18.00)` | |
| [...tilities/deltastreamer/SchedulerConfGenerator.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvU2NoZWR1bGVyQ29uZkdlbmVyYXRvci5qYXZh) | `0.00% <ø> (-90.91%)` | `0.00 <0.00> (-8.00)` | |
| [...apache/hudi/utilities/sources/AvroKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb0thZmthU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [347 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-706792241
I am bit confused about this PR.
Checked out log4j 2, seems like it has some nice advantages. Should we just move to log4j 2?
https://logging.apache.org/log4j/2.x/
https://logging.apache.org/log4j/2.x/manual/messages.html
https://logging.apache.org/log4j/2.x/manual/api.html#LambdaSupport
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (6175e39) into [master](https://codecov.io/gh/apache/hudi/commit/4c5b6923ccfaaa6616a934a3f690b1a795a42d41?el=desc) (4c5b692) will **increase** coverage by `18.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
=============================================
+ Coverage 50.91% 69.51% +18.60%
+ Complexity 3168 357 -2811
=============================================
Files 433 53 -380
Lines 19806 1929 -17877
Branches 2032 229 -1803
=============================================
- Hits 10084 1341 -8743
+ Misses 8904 456 -8448
+ Partials 818 132 -686
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.51% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/hudi/cli/commands/UpgradeOrDowngradeCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1VwZ3JhZGVPckRvd25ncmFkZUNvbW1hbmQuamF2YQ==) | | | |
| [...in/scala/org/apache/hudi/IncrementalRelation.scala](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0luY3JlbWVudGFsUmVsYXRpb24uc2NhbGE=) | | | |
| [...he/hudi/exception/HoodieNotSupportedException.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZU5vdFN1cHBvcnRlZEV4Y2VwdGlvbi5qYXZh) | | | |
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | | | |
| [...ache/hudi/operator/StreamWriteOperatorFactory.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9vcGVyYXRvci9TdHJlYW1Xcml0ZU9wZXJhdG9yRmFjdG9yeS5qYXZh) | | | |
| [...sioning/clean/CleanMetadataV2MigrationHandler.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvY2xlYW4vQ2xlYW5NZXRhZGF0YVYyTWlncmF0aW9uSGFuZGxlci5qYXZh) | | | |
| [...he/hudi/common/table/log/block/HoodieLogBlock.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9ibG9jay9Ib29kaWVMb2dCbG9jay5qYXZh) | | | |
| [...che/hudi/common/table/log/HoodieLogFileReader.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGaWxlUmVhZGVyLmphdmE=) | | | |
| [...udi/common/util/queue/BoundedInMemoryExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvcXVldWUvQm91bmRlZEluTWVtb3J5RXhlY3V0b3IuamF2YQ==) | | | |
| [...e/hudi/common/table/timeline/dto/FileGroupDTO.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL2R0by9GaWxlR3JvdXBEVE8uamF2YQ==) | | | |
| ... and [370 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774672254
@vinothchandar: this PR just upgrade some modules, I will update this PR for all modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-815376490
@wangxianghu: had upgrade to `2.13.3` and fix the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914645144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-679987859
> @wangxianghu Can you help to verify and review this PR?
sure, will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (2fb88d1) into [master](https://codecov.io/gh/apache/hudi/commit/43a0776c7c88a5f7beac6c8853db7e341810635a?el=desc) (43a0776) will **increase** coverage by `18.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
=============================================
+ Coverage 51.14% 69.46% +18.32%
+ Complexity 3215 356 -2859
=============================================
Files 438 53 -385
Lines 20041 1929 -18112
Branches 2064 230 -1834
=============================================
- Hits 10250 1340 -8910
+ Misses 8946 456 -8490
+ Partials 845 133 -712
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/hudi/utilities/HoodieClusteringJob.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZUNsdXN0ZXJpbmdKb2IuamF2YQ==) | `65.21% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [.../apache/hudi/utilities/HoodieSnapshotExporter.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90RXhwb3J0ZXIuamF2YQ==) | `88.79% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/utilities/UtilHelpers.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL1V0aWxIZWxwZXJzLmphdmE=) | `65.69% <ø> (ø)` | `32.00 <0.00> (ø)` | |
| [...callback/kafka/HoodieWriteCommitKafkaCallback.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2NhbGxiYWNrL2thZmthL0hvb2RpZVdyaXRlQ29tbWl0S2Fma2FDYWxsYmFjay5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...udi/utilities/deltastreamer/BootstrapExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvQm9vdHN0cmFwRXhlY3V0b3IuamF2YQ==) | `79.54% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `70.00% <ø> (ø)` | `50.00 <0.00> (ø)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `68.72% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...s/deltastreamer/HoodieMultiTableDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllTXVsdGlUYWJsZURlbHRhU3RyZWFtZXIuamF2YQ==) | `78.39% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...tilities/deltastreamer/SchedulerConfGenerator.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvU2NoZWR1bGVyQ29uZkdlbmVyYXRvci5qYXZh) | `90.90% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/sources/AvroKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb0thZmthU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [312 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-708093601
> @vinothchandar : yes, +1 for move to log4j2. I will do it if necessary.
+1 on moving to log4j2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (2fb88d1) into [master](https://codecov.io/gh/apache/hudi/commit/43a0776c7c88a5f7beac6c8853db7e341810635a?el=desc) (43a0776) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
- Coverage 51.14% 51.09% -0.06%
+ Complexity 3215 3213 -2
============================================
Files 438 438
Lines 20041 20041
Branches 2064 2064
============================================
- Hits 10250 10239 -11
- Misses 8946 8959 +13
+ Partials 845 843 -2
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `36.87% <100.00%> (ø)` | `0.00 <1.00> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.37% <100.00%> (+0.01%)` | `0.00 <1.00> (ø)` | |
| hudiflink | `45.44% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `68.98% <ø> (-0.78%)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/hudi/cli/commands/CompactionCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0NvbXBhY3Rpb25Db21tYW5kLmphdmE=) | `0.80% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/cli/commands/ExportCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0V4cG9ydENvbW1hbmQuamF2YQ==) | `1.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...g/apache/hudi/cli/utils/SparkTempViewProvider.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL3V0aWxzL1NwYXJrVGVtcFZpZXdQcm92aWRlci5qYXZh) | `59.67% <ø> (ø)` | `12.00 <0.00> (ø)` | |
| [...di/common/bootstrap/index/HFileBootstrapIndex.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | `81.48% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...hudi/common/config/DFSPropertiesConfiguration.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZpZy9ERlNQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `78.04% <ø> (ø)` | `14.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | `49.31% <ø> (ø)` | `61.00 <0.00> (ø)` | |
| [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/model/HoodieCommitMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUNvbW1pdE1ldGFkYXRhLmphdmE=) | `42.92% <ø> (ø)` | `43.00 <0.00> (ø)` | |
| [...che/hudi/common/model/HoodiePartitionMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVBhcnRpdGlvbk1ldGFkYXRhLmphdmE=) | `66.66% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| ... and [94 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (77d3697) into [master](https://codecov.io/gh/apache/hudi/commit/e692c704da732c0f2a4d2892729687766a462e53?el=desc) (e692c70) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
- Coverage 52.26% 52.19% -0.07%
+ Complexity 3679 3678 -1
============================================
Files 484 484
Lines 23079 23079
Branches 2457 2457
============================================
- Hits 12063 12047 -16
- Misses 9952 9969 +17
+ Partials 1064 1063 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `36.94% <100.00%> (ø)` | `0.00 <1.00> (ø)` | |
| hudiclient | `∅ <ø> (∅)` | `0.00 <ø> (ø)` | |
| hudicommon | `50.79% <100.00%> (+0.01%)` | `0.00 <1.00> (ø)` | |
| hudiflink | `56.47% <ø> (-0.12%)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.44% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `70.54% <ø> (-0.79%)` | `0.00 <ø> (ø)` | |
| hudisync | `45.47% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `64.36% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.74% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/hudi/cli/commands/CompactionCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0NvbXBhY3Rpb25Db21tYW5kLmphdmE=) | `0.80% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/cli/commands/ExportCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0V4cG9ydENvbW1hbmQuamF2YQ==) | `1.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...g/apache/hudi/cli/utils/SparkTempViewProvider.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL3V0aWxzL1NwYXJrVGVtcFZpZXdQcm92aWRlci5qYXZh) | `59.67% <ø> (ø)` | `12.00 <0.00> (ø)` | |
| [...di/common/bootstrap/index/HFileBootstrapIndex.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | `81.48% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...hudi/common/config/DFSPropertiesConfiguration.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZpZy9ERlNQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `78.04% <ø> (ø)` | `14.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | `47.34% <ø> (ø)` | `57.00 <0.00> (ø)` | |
| [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/model/HoodieCommitMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUNvbW1pdE1ldGFkYXRhLmphdmE=) | `44.87% <ø> (ø)` | `38.00 <0.00> (ø)` | |
| [...che/hudi/common/model/HoodiePartitionMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVBhcnRpdGlvbk1ldGFkYXRhLmphdmE=) | `66.66% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu edited a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
wangxianghu edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-817085349
> @wangxianghu: had upgrade to `2.13.3` and fix the warning.
Hi @hddong thanks for your patient.
we still need `log4j2.properties` or `log4j2.xml` configs right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-686386388
@yanghua @vinothchandar @wangxianghu : make it only use log4j now, please have a review when free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914644392
cc @xushiyan might be good to have this done at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-684143499
> @yanghua yes, I will address this these two days.
Sounds good. Any questions please contact @leesf or let me know. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-807983997
Hi @hddong，I found the newest version of `Apache Log4j` is `2.14.1` for now, how about using `2.13.3` instead of `2.11.0` ?
Besides, I ran the unit test locally and found some `No appenders could be found for logger (org.apache.hadoop.util.Shell)` warnings, It seems `log4j2.properties` is missed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-684122066
> Should we just standardize on log4j instead? (wondering what happened to our slf4j efforts. )
Yes, it would be better to support slf4j as a facade of multiple log frameworks. @hddong Do you have time to support slf4j for hudi? If not, @wangxianghu can you take over this work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-950167052
@hddong sorry that this PR was delayed and resulted in this many conflicts. would you take a look at the conflicts see if resolvable? or you mind opening a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914645144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-961587463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914645144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (04ac800) into [master](https://codecov.io/gh/apache/hudi/commit/43a0776c7c88a5f7beac6c8853db7e341810635a?el=desc) (43a0776) will **increase** coverage by `18.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
=============================================
+ Coverage 51.14% 69.51% +18.37%
+ Complexity 3215 357 -2858
=============================================
Files 438 53 -385
Lines 20041 1929 -18112
Branches 2064 230 -1834
=============================================
- Hits 10250 1341 -8909
+ Misses 8946 456 -8490
+ Partials 845 132 -713
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.51% <ø> (+0.05%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/hudi/utilities/HoodieClusteringJob.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZUNsdXN0ZXJpbmdKb2IuamF2YQ==) | `65.21% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [.../apache/hudi/utilities/HoodieSnapshotExporter.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90RXhwb3J0ZXIuamF2YQ==) | `88.79% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/utilities/UtilHelpers.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL1V0aWxIZWxwZXJzLmphdmE=) | `65.69% <ø> (ø)` | `32.00 <0.00> (ø)` | |
| [...callback/kafka/HoodieWriteCommitKafkaCallback.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2NhbGxiYWNrL2thZmthL0hvb2RpZVdyaXRlQ29tbWl0S2Fma2FDYWxsYmFjay5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...udi/utilities/deltastreamer/BootstrapExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvQm9vdHN0cmFwRXhlY3V0b3IuamF2YQ==) | `79.54% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `70.35% <ø> (+0.35%)` | `51.00 <0.00> (+1.00)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `68.72% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...s/deltastreamer/HoodieMultiTableDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllTXVsdGlUYWJsZURlbHRhU3RyZWFtZXIuamF2YQ==) | `78.39% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...tilities/deltastreamer/SchedulerConfGenerator.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvU2NoZWR1bGVyQ29uZkdlbmVyYXRvci5qYXZh) | `90.90% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/sources/AvroKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb0thZmthU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [308 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] umehrot2 commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
umehrot2 commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-1013527978
@hddong are you still going to work on this ?
If you don't have the bandwidth, I would be happy to drive this to completion and upgrade this further to Log4j 2.17.1 which has fixed several of the major CVEs that have been encountered with Log4j2 recently. Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-819171294
> we still need `log4j2.properties` or `log4j2.xml` configs right?
Yes, dependent on log4j2 config files now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong closed pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong closed pull request #1946:
URL: https://github.com/apache/hudi/pull/1946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (77d3697) into [master](https://codecov.io/gh/apache/hudi/commit/e692c704da732c0f2a4d2892729687766a462e53?el=desc) (e692c70) will **decrease** coverage by `0.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
- Coverage 52.26% 51.95% -0.32%
+ Complexity 3679 3616 -63
============================================
Files 484 478 -6
Lines 23079 22630 -449
Branches 2457 2433 -24
============================================
- Hits 12063 11758 -305
+ Misses 9952 9828 -124
+ Partials 1064 1044 -20
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `36.94% <100.00%> (ø)` | `0.00 <1.00> (ø)` | |
| hudiclient | `∅ <ø> (∅)` | `0.00 <ø> (ø)` | |
| hudicommon | `50.79% <100.00%> (+0.01%)` | `0.00 <1.00> (ø)` | |
| hudiflink | `56.47% <ø> (-0.12%)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.44% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `70.54% <ø> (-0.79%)` | `0.00 <ø> (ø)` | |
| hudisync | `45.47% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.74% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/hudi/cli/commands/CompactionCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0NvbXBhY3Rpb25Db21tYW5kLmphdmE=) | `0.80% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/cli/commands/ExportCommand.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0V4cG9ydENvbW1hbmQuamF2YQ==) | `1.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...g/apache/hudi/cli/utils/SparkTempViewProvider.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL3V0aWxzL1NwYXJrVGVtcFZpZXdQcm92aWRlci5qYXZh) | `59.67% <ø> (ø)` | `12.00 <0.00> (ø)` | |
| [...di/common/bootstrap/index/HFileBootstrapIndex.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | `81.48% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...hudi/common/config/DFSPropertiesConfiguration.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZpZy9ERlNQcm9wZXJ0aWVzQ29uZmlndXJhdGlvbi5qYXZh) | `78.04% <ø> (ø)` | `14.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | `47.34% <ø> (ø)` | `57.00 <0.00> (ø)` | |
| [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/model/HoodieCommitMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUNvbW1pdE1ldGFkYXRhLmphdmE=) | `44.87% <ø> (ø)` | `38.00 <0.00> (ø)` | |
| [...che/hudi/common/model/HoodiePartitionMetadata.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVBhcnRpdGlvbk1ldGFkYXRhLmphdmE=) | `66.66% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| ... and [103 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on a change in pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#discussion_r478444458
##########
File path: hudi-utilities/src/test/resources/log4j2-surefire.properties
##########
@@ -0,0 +1,51 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+status = warn
+name = PropertiesConfig
+
+# CONSOLE is set to be a ConsoleAppender.
+appender.console.type = Console
+appender.console.name = consoleLogger
+# CONSOLE uses PatternLayout.
+appender.console.layout.type = PatternLayout
+appender.console.layout.pattern = %-4r [%t] %-5p %c %x - %m%n
Review comment:
Hi @hddong , thanks for your contribution.
Can you explain why you configured two formats? If there is no special reason, keep them in the same format might be better.
The rest LGTM cc@yanghua
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-784713461
@yanghua @vinothchandar this PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-804760962
@yanghua @vinothchandar: pls have a review when free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-679962745
@wangxianghu Can you help to verify and review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-817085349
> @wangxianghu: had upgrade to `2.13.3` and fix the warning.
Hi @hddong thanks for your patient.
we still need `log4j2.properties` configs right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-686427819
> @yanghua @vinothchandar @wangxianghu : make it only use log4j now, please have a review when free.
@wangxianghu please help to verify, when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774541383
We have discussed log4j, slf4j and log4j2 now. Should we just upgrade to log4j2 across the board and be done with it? :) Is that what this PR does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-950743205
@xushiyan : I will resolve these conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914645144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-686538124
> > @yanghua @vinothchandar @wangxianghu : make it only use log4j now, please have a review when free.
>
> @wangxianghu please help to verify, when you have time.
Ack, will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-707016010
@vinothchandar : yes, +1 for move to log4j2. I will do it if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-683877794
Should we just standardize on log4j instead? (wondering what happened to our slf4j efforts. )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-684137752
@yanghua yes, I will address this these two days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (b7d1d47) into [master](https://codecov.io/gh/apache/hudi/commit/43a0776c7c88a5f7beac6c8853db7e341810635a?el=desc) (43a0776) will **increase** coverage by `18.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
=============================================
+ Coverage 51.14% 69.46% +18.32%
+ Complexity 3215 356 -2859
=============================================
Files 438 53 -385
Lines 20041 1929 -18112
Branches 2064 230 -1834
=============================================
- Hits 10250 1340 -8910
+ Misses 8946 456 -8490
+ Partials 845 133 -712
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/hudi/utilities/HoodieClusteringJob.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZUNsdXN0ZXJpbmdKb2IuamF2YQ==) | `65.21% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [.../apache/hudi/utilities/HoodieSnapshotExporter.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90RXhwb3J0ZXIuamF2YQ==) | `88.79% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/utilities/UtilHelpers.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL1V0aWxIZWxwZXJzLmphdmE=) | `65.69% <ø> (ø)` | `32.00 <0.00> (ø)` | |
| [...callback/kafka/HoodieWriteCommitKafkaCallback.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2NhbGxiYWNrL2thZmthL0hvb2RpZVdyaXRlQ29tbWl0S2Fma2FDYWxsYmFjay5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...udi/utilities/deltastreamer/BootstrapExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvQm9vdHN0cmFwRXhlY3V0b3IuamF2YQ==) | `79.54% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `70.00% <ø> (ø)` | `50.00 <0.00> (ø)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `68.72% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...s/deltastreamer/HoodieMultiTableDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllTXVsdGlUYWJsZURlbHRhU3RyZWFtZXIuamF2YQ==) | `78.39% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...tilities/deltastreamer/SchedulerConfGenerator.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvU2NoZWR1bGVyQ29uZkdlbmVyYXRvci5qYXZh) | `90.90% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/sources/AvroKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb0thZmthU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [307 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=desc) (77d3697) into [master](https://codecov.io/gh/apache/hudi/commit/e692c704da732c0f2a4d2892729687766a462e53?el=desc) (e692c70) will **increase** coverage by `8.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
+ Coverage 52.26% 60.81% +8.55%
+ Complexity 3679 500 -3179
============================================
Files 484 70 -414
Lines 23079 3152 -19927
Branches 2457 367 -2090
============================================
- Hits 12063 1917 -10146
+ Misses 9952 1049 -8903
+ Partials 1064 186 -878
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `45.47% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `69.74% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/hudi/dla/DLASyncTool.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktZGxhLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZGxhL0RMQVN5bmNUb29sLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/java/org/apache/hudi/dla/HoodieDLAClient.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktZGxhLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZGxhL0hvb2RpZURMQUNsaWVudC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSGl2ZVN5bmNUb29sLmphdmE=) | `70.37% <ø> (ø)` | `17.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/hive/HoodieHiveClient.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSG9vZGllSGl2ZUNsaWVudC5qYXZh) | `73.66% <ø> (ø)` | `41.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `69.31% <ø> (ø)` | `43.00 <0.00> (ø)` | |
| [...org/apache/hudi/utilities/HoodieClusteringJob.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZUNsdXN0ZXJpbmdKb2IuamF2YQ==) | `65.21% <ø> (ø)` | `9.00 <0.00> (ø)` | |
| [.../apache/hudi/utilities/HoodieSnapshotExporter.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90RXhwb3J0ZXIuamF2YQ==) | `88.79% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [...in/java/org/apache/hudi/utilities/UtilHelpers.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL1V0aWxIZWxwZXJzLmphdmE=) | `64.53% <ø> (ø)` | `33.00 <0.00> (ø)` | |
| [...callback/kafka/HoodieWriteCommitKafkaCallback.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2NhbGxiYWNrL2thZmthL0hvb2RpZVdyaXRlQ29tbWl0S2Fma2FDYWxsYmFjay5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...udi/utilities/deltastreamer/BootstrapExecutor.java](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvQm9vdHN0cmFwRXhlY3V0b3IuamF2YQ==) | `82.35% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/hudi/pull/1946/diff?src=pr&el=tree-more) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-914645144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #1946: [HUDI-1176]Support log4j2 config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-774846457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #1946: [HUDI-1176]Upgrade tp log4j2
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #1946:
URL: https://github.com/apache/hudi/pull/1946#issuecomment-961587463
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081",
"triggerID" : "8b343f593ce18c95ea1c4cc87683a2381d000ba6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b343f593ce18c95ea1c4cc87683a2381d000ba6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2081)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org