You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/30 09:07:05 UTC

[GitHub] [shardingsphere] Pace2Car opened a new pull request, #22534: Refactor class-based-sharding-algorithm-example with ShardingSphereDriver

Pace2Car opened a new pull request, #22534:
URL: https://github.com/apache/shardingsphere/pull/22534

   For #22469 .
   
   Changes proposed in this pull request:
     - Refactor class-based-sharding-algorithm-example with ShardingSphereDriver
     - Remove Spring configuration example
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #22534: Refactor class-based-sharding-algorithm-example with ShardingSphereDriver

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22534:
URL: https://github.com/apache/shardingsphere/pull/22534#issuecomment-1331881799

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22534](https://codecov.io/gh/apache/shardingsphere/pull/22534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8b0bfa) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7e6d00dbfab5f016fae7736f805c34df469a2907?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e6d00d) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #22534   +/-   ##
   =========================================
     Coverage     50.93%   50.94%           
     Complexity     2515     2515           
   =========================================
     Files          4189     4189           
     Lines         58290    58290           
     Branches       9912     9912           
   =========================================
   + Hits          29692    29695    +3     
   + Misses        26067    26064    -3     
     Partials       2531     2531           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang merged pull request #22534: Refactor class-based-sharding-algorithm-example with ShardingSphereDriver

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22534:
URL: https://github.com/apache/shardingsphere/pull/22534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org