You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/05/25 05:36:08 UTC
incubator-kudu git commit: service_pool: only log queue overflows
once per second
Repository: incubator-kudu
Updated Branches:
refs/heads/branch-0.9.x 90832f17f -> dc2e0dc3b
service_pool: only log queue overflows once per second
These queue overflow messages are extremely frequent on stress
workloads, and I found that the log spew itself caused the server to
block on glog locks, compounding the problem. Spewing these messages is
rarely helpful, so this patch throttles it to once a second.
Change-Id: I636ef39798f9b2ab7d8aec237285c949ec119468
Reviewed-on: http://gerrit.cloudera.org:8080/3185
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans
(cherry picked from commit 298806fa32c44e986c2401fa5ac416bcbc491523)
Reviewed-on: http://gerrit.cloudera.org:8080/3197
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/dc2e0dc3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/dc2e0dc3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/dc2e0dc3
Branch: refs/heads/branch-0.9.x
Commit: dc2e0dc3b862ccc407f2518af671215c6f1e1a81
Parents: 90832f1
Author: Todd Lipcon <to...@cloudera.com>
Authored: Mon May 23 21:49:10 2016 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Wed May 25 05:32:39 2016 +0000
----------------------------------------------------------------------
src/kudu/rpc/service_pool.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/dc2e0dc3/src/kudu/rpc/service_pool.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/service_pool.cc b/src/kudu/rpc/service_pool.cc
index 78ba6a0..d089350 100644
--- a/src/kudu/rpc/service_pool.cc
+++ b/src/kudu/rpc/service_pool.cc
@@ -29,6 +29,7 @@
#include "kudu/rpc/service_if.h"
#include "kudu/rpc/service_queue.h"
#include "kudu/gutil/strings/substitute.h"
+#include "kudu/util/logging.h"
#include "kudu/util/metrics.h"
#include "kudu/util/status.h"
#include "kudu/util/thread.h"
@@ -113,7 +114,7 @@ void ServicePool::RejectTooBusy(InboundCall* c) {
c->remote_address().ToString(),
service_queue_.max_size());
rpcs_queue_overflow_->Increment();
- LOG(WARNING) << err_msg;
+ KLOG_EVERY_N_SECS(WARNING, 1) << err_msg;
c->RespondFailure(ErrorStatusPB::ERROR_SERVER_TOO_BUSY,
Status::ServiceUnavailable(err_msg));
DLOG(INFO) << err_msg << " Contents of service queue:\n"