You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/08/12 15:15:59 UTC

[GitHub] [hop] utkarshutr opened a new pull request, #1630: Add an additional jar for Spark local run

utkarshutr opened a new pull request, #1630:
URL: https://github.com/apache/hop/pull/1630

   To run spark in local, there are some libraries which need to be added. common-text jar is missing in the list. Without this jar, you will not able to see Application Detail UI. Tested from my side, after adding this library able to see the Application Detail UI page.
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
          where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
    
   Trivial changes like typos do not require a JIRA issue (javadoc, comments...). 
   In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #1630: Add an additional jar for Spark local run

Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1630:
URL: https://github.com/apache/hop/pull/1630#issuecomment-1213422769

   Will take a look to see if we can add it as a default jar or if it indeed needs to be added to the guide.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] utkarshutr commented on pull request #1630: Add an additional jar for Spark local run

Posted by GitBox <gi...@apache.org>.
utkarshutr commented on PR #1630:
URL: https://github.com/apache/hop/pull/1630#issuecomment-1214192270

   > Will take a look to see if we can add it as a default jar or if it indeed needs to be added to the guide.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #1630: Add an additional jar for Spark local run

Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1630:
URL: https://github.com/apache/hop/pull/1630#issuecomment-1246339321

   Added the library to the release, so this doc change is no longer needed.
   change here: https://github.com/apache/hop/pull/1682/commits/8e54ad51e7a4b284374a00f4caab3900eab031dc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva closed pull request #1630: Add an additional jar for Spark local run

Posted by GitBox <gi...@apache.org>.
hansva closed pull request #1630: Add an additional jar for Spark local run
URL: https://github.com/apache/hop/pull/1630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org