You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/04/21 21:02:54 UTC
Review Request 46506: Fix bug when fetching a task with multiple
assigned ports.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46506/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1672
https://issues.apache.org/jira/browse/AURORA-1672
Repository: aurora
Description
-------
Because we did not include the ids for task ports and task events in the query when mybatis tried
to map the results, there was no way to identify the task events returned in each additional row
for ports as distinct. This resulted in each subsequent task fetch tacking on extra task events.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml fb78a3952c99de828945e84fc218873ea21dbbc5
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 310c4d8e34ad75c080a22e30343c7da6d4a01e3c
Diff: https://reviews.apache.org/r/46506/diff/
Testing
-------
Distilled down to the added test case which verifies the fix.
Also verified the fix in the UI.
Thanks,
Joshua Cohen
Re: Review Request 46506: Fix bug when fetching a task with multiple
assigned ports.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46506/#review129939
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 21, 2016, 7:02 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46506/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 7:02 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1672
> https://issues.apache.org/jira/browse/AURORA-1672
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Because we did not include the ids for task ports and task events in the query when mybatis tried
> to map the results, there was no way to identify the task events returned in each additional row
> for ports as distinct. This resulted in each subsequent task fetch tacking on extra task events.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml fb78a3952c99de828945e84fc218873ea21dbbc5
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 310c4d8e34ad75c080a22e30343c7da6d4a01e3c
>
> Diff: https://reviews.apache.org/r/46506/diff/
>
>
> Testing
> -------
>
> Distilled down to the added test case which verifies the fix.
>
> Also verified the fix in the UI.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46506: Fix bug when fetching a task with multiple
assigned ports.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46506/#review129940
-----------------------------------------------------------
Ship it!
Master (15eaa5d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 21, 2016, 7:02 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46506/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 7:02 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1672
> https://issues.apache.org/jira/browse/AURORA-1672
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Because we did not include the ids for task ports and task events in the query when mybatis tried
> to map the results, there was no way to identify the task events returned in each additional row
> for ports as distinct. This resulted in each subsequent task fetch tacking on extra task events.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml fb78a3952c99de828945e84fc218873ea21dbbc5
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 310c4d8e34ad75c080a22e30343c7da6d4a01e3c
>
> Diff: https://reviews.apache.org/r/46506/diff/
>
>
> Testing
> -------
>
> Distilled down to the added test case which verifies the fix.
>
> Also verified the fix in the UI.
>
>
> Thanks,
>
> Joshua Cohen
>
>