[GitHub] rabbah commented on a change in pull request #4221: during api create, correctly handle non-default (i.e. "_") namespaces

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4221: during api create, correctly handle non-default (i.e. "_") namespaces
URL: https://github.com/apache/incubator-openwhisk/pull/4221#discussion_r248499287
 
 

 ##########
 File path: core/routemgmt/common/apigw-utils.js
 ##########
 @@ -853,7 +853,8 @@ function updateNamespace(apidoc, namespace) {
     if (apidoc.action) {
       // The action namespace does not have to match the CLI user's namespace
       // If it is different, leave it alone; otherwise use the replacement namespace
-      if (apidoc.namespace === apidoc.action.namespace) {
+      // And only replace when the namespace is the default '_' which needs replacement
+      if (apidoc.namespace === apidoc.action.namespace && apidoc.namespace === '_') {
 
 Review comment:
   The cli allows on to set their own namespace. It’s not as useful now because the key is 1-1 with the namespace. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services