You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/14 10:29:43 UTC

[GitHub] [commons-lang] bndhanush opened a new pull request #675: LANG-1444

bndhanush opened a new pull request #675:
URL: https://github.com/apache/commons-lang/pull/675


   NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls edited a comment on pull request #675: LANG-1444

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745948308


   
   [![Coverage Status](https://coveralls.io/builds/35843115/badge)](https://coveralls.io/builds/35843115)
   
   Coverage increased (+0.0003%) to 95.016% when pulling **8f0382441504cc4d0a01efc33b14d130918acfd1 on bndhanush:master** into **615eee5d51e14a00f0f7dd0ff7846cd4d7ae9a9e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] bndhanush commented on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Posted by GitBox <gi...@apache.org>.
bndhanush commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-776695814


   @chtompki and @garydgregory. 
   Can you please help in checking if the PR is valid. Also suggest if any changes are required.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] bndhanush commented on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Posted by GitBox <gi...@apache.org>.
bndhanush commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-786579783


   hi @garydgregory 
   
   Thanks for the input. 
   I added test case to ensure that precision is not lost and we maintain the value. 
   
   Please validate the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-752134326


   @chtompki 
   May you please validate this one?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #675: LANG-1444

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745948308


   
   [![Coverage Status](https://coveralls.io/builds/35755438/badge)](https://coveralls.io/builds/35755438)
   
   Coverage increased (+0.0003%) to 95.016% when pulling **8f0382441504cc4d0a01efc33b14d130918acfd1 on bndhanush:master** into **615eee5d51e14a00f0f7dd0ff7846cd4d7ae9a9e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls edited a comment on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745948308


   
   [![Coverage Status](https://coveralls.io/builds/37476042/badge)](https://coveralls.io/builds/37476042)
   
   Coverage decreased (-0.1%) to 94.915% when pulling **548c4126dae9dd5256ad831ac6fb382b93add158 on bndhanush:master** into **615eee5d51e14a00f0f7dd0ff7846cd4d7ae9a9e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-782873331


   Hi @bndhanush 
   Thank you for your PR.
   In the new test, I do not think it is enough to check that an instance of right class is created, you want to check that the right _value_ is created to make sure we do not have the opposite issue: loosing precision.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] bndhanush commented on pull request #675: LANG-1444

Posted by GitBox <gi...@apache.org>.
bndhanush commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745846181


   Hi @garydgregory,
   
   I have fixed the formatting issue. I see it is ok for the 16-ea build to fail, is that correct understanding? 
   I am pretty new to OS, can you please help me in this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] bndhanush edited a comment on pull request #675: LANG-1444

Posted by GitBox <gi...@apache.org>.
bndhanush edited a comment on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745846181


   Hi @garydgregory,
   
   Thank you for the notice. I have fixed the formatting issue. I see it is ok for the 16-ea build to fail, is that correct understanding? 
   I am pretty new to OS, can you please help me in this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #675: LANG-1444

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #675:
URL: https://github.com/apache/commons-lang/pull/675#issuecomment-744438212


   @bndhanush 
   This PR breaks the build, please see https://github.com/apache/commons-lang/pull/675/checks?check_run_id=1549559036


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org