You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/28 15:17:01 UTC
[GitHub] pnowojski commented on a change in pull request #7186:
[FLINK-10941] Keep slots which contain unconsumed result partitions
pnowojski commented on a change in pull request #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r261228249
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -134,10 +138,17 @@ public void cancel(InputChannelID receiverId) {
ctx.pipeline().fireUserEventTriggered(receiverId);
}
- public void close() {
+ public void close() throws IOException {
if (ctx != null) {
ctx.channel().close();
}
+
+ LOG.info("Close all {} readers pending for close.", readersToClose.size());
+ for (NetworkSequenceViewReader reader : readersToClose) {
Review comment:
Do you need `readersToClose`? Can not you iterate over `allReaders`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services