[GitHub] [spark] zhouyejoe commented on a change in pull request #34276: [SPARK-36998][CORE] Handle concurrent eviction of same application in SHS

[GitBox <gi...@apache.org>]

zhouyejoe commented on a change in pull request #34276:
URL: https://github.com/apache/spark/pull/34276#discussion_r730221366



##########
File path: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerDiskManagerSuite.scala
##########
@@ -158,6 +159,19 @@ class HistoryServerDiskManagerSuite extends SparkFunSuite with BeforeAndAfter {
     assert(manager.approximateSize(50L, true) > 50L)
   }
 
+  test("Should be able to delete a store") {
+    val manager = mockManager()
+    val tempDir = Utils.createTempDir()
+    val deleteStore = PrivateMethod[Unit]('deleteStore)
+    try {
+      manager invokePrivate deleteStore(tempDir)

Review comment:
       Can we just try calling the method twice? And just check whether there is any exception thrown out. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org