[GitHub] storm pull request #1965: STORM-2380 worker.childopts with whitespace inside...

[nilday <gi...@git.apache.org>]

GitHub user nilday opened a pull request:

    https://github.com/apache/storm/pull/1965

    STORM-2380 worker.childopts with whitespace inside one param

    This pattern matches
    1.everything starts with -XX:\w+ or -D[\w.]+ and followed with quoted (both ' and ") strings
    2.everything without \s, ' and " in it
    This will solve the problem which params like -XX:OnError="pstack %p >~/pstack%p.log" will be split into pieces

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nilday/storm 1.0.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1965
    
----
commit a8d2ac597706f9c1af34e3ab775a141e605eae84
Author: howard.li <ho...@vipshop.com>
Date:   2017-02-24T10:02:08Z

    modify BasicContainer.substituteChildOpts to deal with opts with space inside it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1965: STORM-2380 worker.childopts with whitespace inside...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1965


---