[GitHub] [arrow] assignUser commented on a diff in pull request #36862: GH-36861: [CI] Temporary cache nasm from GitHub to fix VCPKG job

["assignUser (via GitHub)" <gi...@apache.org>]

assignUser commented on code in PR #36862:
URL: https://github.com/apache/arrow/pull/36862#discussion_r1274314770


##########
dev/tasks/vcpkg-tests/github.windows.yml:
##########
@@ -73,6 +73,14 @@ jobs:
           `vcpkg fetch nuget | tail -n 1` \
             setapikey "$GITHUB_TOKEN" \
             -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Cache nasm
+        run: |
+          # echo "VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" | Out-File -FilePath $env:GITHUB_ENV -Append
+          New-Item -ItemType "directory" -Path "C:\vcpkg\downloads" -Force
+          Invoke-WebRequest -URI "$env:BASE_URL/$env:FILE_NAME" -OutFile "C:\vcpkg\downloads\$env:FILE_NAME"
+        env:
+          BASE_URL: https://github.com/microsoft/vcpkg/files/12073957
+          FILE_NAME: nasm-2.16.01-win64.zip

Review Comment:
   hm I think creating the downloads folder in `$GITHUB_WORKSPACE` ~~and using github.com/actions/cache to cache that~~ (no normal caching in crossbow...) in combination with the download script you have should work + maybe a check for `$GITHUB_ACTIONS` in *vcpkg.bat to avoid adding that option when not in gha (probably not used by anyone locally but how knows...)?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org