You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/16 13:00:52 UTC
[GitHub] [rocketmq] saltyx opened a new pull request #2001: [ISSUES#1989] refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
saltyx opened a new pull request #2001:
URL: https://github.com/apache/rocketmq/pull/2001
## What is the purpose of the change
issue#1989
## Brief changelog
refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] saltyx commented on pull request #2001: [ISSUES#1989] refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
Posted by GitBox <gi...@apache.org>.
saltyx commented on pull request #2001:
URL: https://github.com/apache/rocketmq/pull/2001#issuecomment-629646129
#1989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2001: [ISSUES#1989] refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2001:
URL: https://github.com/apache/rocketmq/pull/2001#issuecomment-629645427
[](https://coveralls.io/builds/30832836)
Coverage decreased (-0.09%) to 50.863% when pulling **75ee2503ac2c77a512ee6fcf8c3db278efb61a73 on saltyx:fix_namesrv_registerbroker** into **7f105361022f3a0de8c1d6feda04d5eba3dba6bb on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2001: [ISSUES#1989] refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2001:
URL: https://github.com/apache/rocketmq/pull/2001#issuecomment-629650847
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=h1) Report
> Merging [#2001](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/7f105361022f3a0de8c1d6feda04d5eba3dba6bb&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `90.90%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2001 +/- ##
=============================================
+ Coverage 45.05% 45.08% +0.03%
- Complexity 4192 4198 +6
=============================================
Files 545 545
Lines 35732 35743 +11
Branches 4744 4746 +2
=============================================
+ Hits 16100 16116 +16
+ Misses 17588 17585 -3
+ Partials 2044 2042 -2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vUm91dGVJbmZvTWFuYWdlci5qYXZh) | `40.77% <90.90%> (+1.65%)` | `34.00 <4.00> (+6.00)` | |
| [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `46.61% <0.00%> (-3.59%)` | `33.00% <0.00%> (ø%)` | |
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `64.86% <0.00%> (-2.71%)` | `19.00% <0.00%> (-1.00%)` | |
| [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | `25.00% <0.00%> (-1.00%)` | |
| [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.60% <0.00%> (-0.32%)` | `3.00% <0.00%> (ø%)` | |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `46.02% <0.00%> (-0.30%)` | `80.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | `30.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `67.25% <0.00%> (+0.10%)` | `80.00% <0.00%> (ø%)` | |
| ... and [5 more](https://codecov.io/gh/apache/rocketmq/pull/2001/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=footer). Last update [7f10536...75ee250](https://codecov.io/gh/apache/rocketmq/pull/2001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2001: [ISSUES#1989] refresh namesrv's brokerAddrTable and clusterAddrTable according to ip:port when registering brokers
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2001:
URL: https://github.com/apache/rocketmq/pull/2001#issuecomment-629645427
[](https://coveralls.io/builds/30832350)
Coverage decreased (-0.1%) to 50.854% when pulling **35a62ec7e8778eb15041a34ea8ac8995c02da002 on saltyx:fix_namesrv_registerbroker** into **7f105361022f3a0de8c1d6feda04d5eba3dba6bb on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org