You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/07 01:57:50 UTC
[GitHub] [dolphinscheduler] baisui1981 opened a new pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
baisui1981 opened a new pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
relevant ISSUE:[https://github.com/apache/dolphinscheduler/issues/6444](https://github.com/apache/dolphinscheduler/issues/6444)
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763594484
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
+ },
+ helpUrl: function (tskType) {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987544343
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763575820
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
Review comment:
const type = tasksType[typeKey]
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
+ },
+ helpUrl: function (tskType) {
Review comment:
tasktype => {}
Here `tsktype` should be replaced with `tasktype`.
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
typekey => {}
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
Review comment:
if (!type) return false
const disabled = !! type.helperLinkDisable
return !disabled
There are three inversion operations here, can't it be simplified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987544343
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763575603
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
typekey => {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987501108
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7226](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b683b4) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ff9bc806ac04d07ff0581e7a88514f943310d2c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff9bc80) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7226 +/- ##
=========================================
Coverage 40.37% 40.37%
Complexity 3679 3679
=========================================
Files 648 648
Lines 27065 27065
Branches 3035 3035
=========================================
Hits 10928 10928
Misses 15101 15101
Partials 1036 1036
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ff9bc80...1b683b4](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Wangyizhi1 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
Wangyizhi1 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763580103
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
Functions should be written in methods. [methods](https://cn.vuejs.org/v2/api/#methods)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs merged pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-988549002
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-988552122
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987504361
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987501108
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7226](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebc702a) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ff9bc806ac04d07ff0581e7a88514f943310d2c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff9bc80) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7226 +/- ##
============================================
+ Coverage 40.37% 40.39% +0.02%
- Complexity 3679 3681 +2
============================================
Files 648 648
Lines 27065 27065
Branches 3035 3035
============================================
+ Hits 10928 10934 +6
+ Misses 15101 15093 -8
- Partials 1036 1038 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.52% <0.00%> (+1.40%)` | :arrow_up: |
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `40.00% <0.00%> (+2.22%)` | :arrow_up: |
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `64.04% <0.00%> (+3.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ff9bc80...ebc702a](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r764589313
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
ok, i have catch your idea, and have modified it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987561635
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763594803
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -17,7 +17,10 @@
<template>
<div class="form-model-wrapper" v-clickoutside="_handleClose">
<div class="title-box">
- <span class="name">{{ $t("Current node settings") }}</span>
+ <span class="name">{{ $t("Current node settings") }}
+ <a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank"
+ :href="helpUrl(nodeData.taskType)">?{{nodeData.taskType}} {{ $t('Instructions') }}</a>
Review comment:
tks, you have provided so beautify icon
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763584897
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -17,7 +17,10 @@
<template>
<div class="form-model-wrapper" v-clickoutside="_handleClose">
<div class="title-box">
- <span class="name">{{ $t("Current node settings") }}</span>
+ <span class="name">{{ $t("Current node settings") }}
+ <a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank"
+ :href="helpUrl(nodeData.taskType)">?{{nodeData.taskType}} {{ $t('Instructions') }}</a>
Review comment:
<i class="el-icon-question" />
{{nodeData.taskType}} {{ $t('Instructions') }}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763584897
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -17,7 +17,10 @@
<template>
<div class="form-model-wrapper" v-clickoutside="_handleClose">
<div class="title-box">
- <span class="name">{{ $t("Current node settings") }}</span>
+ <span class="name">{{ $t("Current node settings") }}
+ <a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank"
+ :href="helpUrl(nodeData.taskType)">?{{nodeData.taskType}} {{ $t('Instructions') }}</a>
Review comment:
It is recommended to change the question mark to an icon. The icon can be set in the same style as the text.
``` vue
<a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank" :href="helpUrl(nodeData.taskType)">
<i class="el-icon-question" />
{{nodeData.taskType}} {{ $t('Instructions') }}
</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763584897
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -17,7 +17,10 @@
<template>
<div class="form-model-wrapper" v-clickoutside="_handleClose">
<div class="title-box">
- <span class="name">{{ $t("Current node settings") }}</span>
+ <span class="name">{{ $t("Current node settings") }}
+ <a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank"
+ :href="helpUrl(nodeData.taskType)">?{{nodeData.taskType}} {{ $t('Instructions') }}</a>
Review comment:
It is recommended to change the question mark to an icon. The icon can be set in the same style as the text.
``` vue
<i class="el-icon-question" />
{{nodeData.taskType}} {{ $t('Instructions') }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763584897
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -17,7 +17,10 @@
<template>
<div class="form-model-wrapper" v-clickoutside="_handleClose">
<div class="title-box">
- <span class="name">{{ $t("Current node settings") }}</span>
+ <span class="name">{{ $t("Current node settings") }}
+ <a v-if="helpUrlEnable(nodeData.taskType)" class="helper-link" target="_blank"
+ :href="helpUrl(nodeData.taskType)">?{{nodeData.taskType}} {{ $t('Instructions') }}</a>
Review comment:
It is recommended to change the question mark to an icon. The icon can be set in the same style as the text.
<i class="el-icon-question" />
{{nodeData.taskType}} {{ $t('Instructions') }}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987504361
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987534974
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763594310
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
Review comment:
ok , has been modified
``` javascript
helpUrlEnable: function (typeKey) {
const type = tasksType[typeKey]
if (type) {
if (!type.helperLinkDisable) return true
return !type.helperLinkDisable
}
return false
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763595059
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987501108
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7226](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c9dd34) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ff9bc806ac04d07ff0581e7a88514f943310d2c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff9bc80) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7226 +/- ##
============================================
+ Coverage 40.37% 40.40% +0.02%
- Complexity 3679 3680 +1
============================================
Files 648 648
Lines 27065 27065
Branches 3035 3035
============================================
+ Hits 10928 10936 +8
+ Misses 15101 15091 -10
- Partials 1036 1038 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/plugin/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS9kb2xwaGluc2NoZWR1bGVyLXJlZ2lzdHJ5LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3JlZ2lzdHJ5L3pvb2tlZXBlci9ab29rZWVwZXJSZWdpc3RyeS5qYXZh) | `54.54% <0.00%> (+7.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ff9bc80...4c9dd34](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987534974
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7226&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7226&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r764584493
##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
then when i add **methods** ,vue module throw an exception as blow, is there something invalid for me ?
```
vue.runtime.esm.js?2b0e:1897 TypeError: _vm.helpUrlEnable is not a function
at Proxy.render (formModel.vue?d1b5:22)
at VueComponent.Vue._render (vue.runtime.esm.js?2b0e:3569)
at VueComponent.updateComponent (vue.runtime.esm.js?2b0e:4081)
at Watcher.get (vue.runtime.esm.js?2b0e:4495)
at new Watcher (vue.runtime.esm.js?2b0e:4484)
at mountComponent (vue.runtime.esm.js?2b0e:4088)
at VueComponent.Vue.$mount (vue.runtime.esm.js?2b0e:8459)
at init (vue.runtime.esm.js?2b0e:3137)
at createComponent (vue.runtime.esm.js?2b0e:6022)
at createElm (vue.runtime.esm.js?2b0e:5969)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#issuecomment-987501108
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7226](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bedee36) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ff9bc806ac04d07ff0581e7a88514f943310d2c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff9bc80) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7226 +/- ##
============================================
+ Coverage 40.37% 40.43% +0.06%
- Complexity 3679 3680 +1
============================================
Files 648 648
Lines 27065 27027 -38
Branches 3035 3034 -1
============================================
+ Hits 10928 10929 +1
+ Misses 15101 15055 -46
- Partials 1036 1043 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/api/aspect/AccessLogAspect.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2FzcGVjdC9BY2Nlc3NMb2dBc3BlY3QuamF2YQ==) | `80.95% <0.00%> (-3.67%)` | :arrow_down: |
| [...inscheduler/remote/command/CacheExpireCommand.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ2FjaGVFeHBpcmVDb21tYW5kLmphdmE=) | `78.57% <0.00%> (-2.68%)` | :arrow_down: |
| [...uler/api/service/impl/DataAnalysisServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhQW5hbHlzaXNTZXJ2aWNlSW1wbC5qYXZh) | `80.00% <0.00%> (-2.06%)` | :arrow_down: |
| [...r/api/service/impl/WorkFlowLineageServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Xb3JrRmxvd0xpbmVhZ2VTZXJ2aWNlSW1wbC5qYXZh) | `35.35% <0.00%> (-0.73%)` | :arrow_down: |
| [...er/api/service/impl/TaskDefinitionServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9UYXNrRGVmaW5pdGlvblNlcnZpY2VJbXBsLmphdmE=) | `31.83% <0.00%> (-0.63%)` | :arrow_down: |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `35.29% <0.00%> (-0.38%)` | :arrow_down: |
| [...er/server/master/runner/WorkflowExecuteThread.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvV29ya2Zsb3dFeGVjdXRlVGhyZWFkLmphdmE=) | `9.97% <0.00%> (-0.12%)` | :arrow_down: |
| [...nscheduler/api/controller/SchedulerController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvU2NoZWR1bGVyQ29udHJvbGxlci5qYXZh) | `73.91% <0.00%> (ø)` | |
| [...uler/server/master/runner/EventExecuteService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvRXZlbnRFeGVjdXRlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...er/plugin/datasource/api/utils/DatasourceUtil.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS91dGlscy9EYXRhc291cmNlVXRpbC5qYXZh) | | |
| ... and [6 more](https://codecov.io/gh/apache/dolphinscheduler/pull/7226/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ff9bc80...bedee36](https://codecov.io/gh/apache/dolphinscheduler/pull/7226?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org