You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Weston Pace (Jira)" <ji...@apache.org> on 2021/09/03 03:15:00 UTC
[jira] [Updated] (ARROW-13873) [C++] Duplicate functions
array_filter/array_take and filter/take
[ https://issues.apache.org/jira/browse/ARROW-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston Pace updated ARROW-13873:
--------------------------------
Description:
This has been explained to me as a metafunction and a backend but in that case the backend should not be registered with the function registry. Note both:
{code:cpp}
const FunctionDoc filter_doc(
"Filter with a boolean selection filter",
("The output is populated with values from the input at positions\n"
"where the selection filter is non-zero. Nulls in the selection filter\n"
"are handled based on FilterOptions."),
{"input", "selection_filter"}, "FilterOptions");
{code}
and
{code:cpp}
const FunctionDoc array_filter_doc(
"Filter with a boolean selection filter",
("The output is populated with values from the input `array` at positions\n"
"where the selection filter is non-zero. Nulls in the selection filter\n"
"are handled based on FilterOptions."),
{"array", "selection_filter"}, "FilterOptions");
{code}
which seems wrong as well.
Also sort_indices / array_sort_indices
was:
This has been explained to me as a metafunction and a backend but in that case the backend should not be registered with the function registry. Note both:
{code:cpp}
const FunctionDoc filter_doc(
"Filter with a boolean selection filter",
("The output is populated with values from the input at positions\n"
"where the selection filter is non-zero. Nulls in the selection filter\n"
"are handled based on FilterOptions."),
{"input", "selection_filter"}, "FilterOptions");
{code}
and
{code:cpp}
const FunctionDoc array_filter_doc(
"Filter with a boolean selection filter",
("The output is populated with values from the input `array` at positions\n"
"where the selection filter is non-zero. Nulls in the selection filter\n"
"are handled based on FilterOptions."),
{"array", "selection_filter"}, "FilterOptions");
{code}
which seems wrong as well.
> [C++] Duplicate functions array_filter/array_take and filter/take
> -----------------------------------------------------------------
>
> Key: ARROW-13873
> URL: https://issues.apache.org/jira/browse/ARROW-13873
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Weston Pace
> Priority: Major
>
> This has been explained to me as a metafunction and a backend but in that case the backend should not be registered with the function registry. Note both:
> {code:cpp}
> const FunctionDoc filter_doc(
> "Filter with a boolean selection filter",
> ("The output is populated with values from the input at positions\n"
> "where the selection filter is non-zero. Nulls in the selection filter\n"
> "are handled based on FilterOptions."),
> {"input", "selection_filter"}, "FilterOptions");
> {code}
> and
> {code:cpp}
> const FunctionDoc array_filter_doc(
> "Filter with a boolean selection filter",
> ("The output is populated with values from the input `array` at positions\n"
> "where the selection filter is non-zero. Nulls in the selection filter\n"
> "are handled based on FilterOptions."),
> {"array", "selection_filter"}, "FilterOptions");
> {code}
> which seems wrong as well.
> Also sort_indices / array_sort_indices
--
This message was sent by Atlassian Jira
(v8.3.4#803005)