You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/07/19 15:55:31 UTC
[GitHub] [datasketches-java] leerho opened a new pull request, #408: Quantiles sketch sorted view
leerho opened a new pull request, #408:
URL: https://github.com/apache/datasketches-java/pull/408
Alex is OOV for 3 weeks, so I am going to complete this work that he started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on pull request #408: Quantiles sketch sorted view
Posted by GitBox <gi...@apache.org>.
leerho commented on PR #408:
URL: https://github.com/apache/datasketches-java/pull/408#issuecomment-1191842075
I have reviewed these changes and I approve. But because I created the PR, I cannot click "approve".
The only comment is that we should also change the internal variables like "aux" to "sortedView" or "sv", but we can do that later. Since you obviously approve, I will do the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #408: Quantiles sketch sorted view
Posted by GitBox <gi...@apache.org>.
leerho merged PR #408:
URL: https://github.com/apache/datasketches-java/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org