You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/14 14:26:00 UTC

[jira] [Commented] (NIFI-5311) Wait a bit for components to finish validation on creation

    [ https://issues.apache.org/jira/browse/NIFI-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512537#comment-16512537 ] 

ASF GitHub Bot commented on NIFI-5311:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2795

    NIFI-5311: When creating a processor, controller service, or reportin…

    …g task, give the component up to 50 ms to complete validation before returning the DTO
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2795
    
----
commit 86881a7b64128e149c70a3c08286de43807fc10a
Author: Mark Payne <ma...@...>
Date:   2018-06-14T14:24:24Z

    NIFI-5311: When creating a processor, controller service, or reporting task, give the component up to 50 ms to complete validation before returning the DTO

----


> Wait a bit for components to finish validation on creation
> ----------------------------------------------------------
>
>                 Key: NIFI-5311
>                 URL: https://issues.apache.org/jira/browse/NIFI-5311
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.7.0
>
>
> In NIFI-5279, we updated the framework so that we won't return web requests that update components until either the component's validation completes or we wait 50 milliseconds. We should do the same when creating components. Otherwise, we end up seeing "Validating..." quite often when a component is created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)