You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/09 16:05:37 UTC
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/313
componentize: add confirmbutton component
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton confirm-butto
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit acb4b2de6c38985c139dc64504848285aeb6839e
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-09T15:04:15Z
componentize: add confirmbutton component
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#issuecomment-77870473
we will use that one in mango and other screens
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#discussion_r26672369
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -188,7 +188,20 @@ function (app, FauxtonAPI, React, Components, beautifyHelper) {
}
});
+ var ConfirmButton = React.createClass({
--- End diff --
it is called confirmbutton because it
```
btn-success save
```
and
```
fonticon-ok-circled
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#discussion_r26660463
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -188,7 +188,20 @@ function (app, FauxtonAPI, React, Components, beautifyHelper) {
}
});
+ var ConfirmButton = React.createClass({
--- End diff --
Maybe we should rather call it a `SubmitButton`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#issuecomment-83019522
Thanks for the explanation. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize: add confirmbutton comp...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#issuecomment-86490299
merged as 1de65dc28ce85aa1e3a2f4f102df6fd70a66235e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---