You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/04 18:02:45 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #28067: WIP: Refactor serialize

ashb commented on code in PR #28067:
URL: https://github.com/apache/airflow/pull/28067#discussion_r1039008837


##########
airflow/models/serialized_dag.py:
##########
@@ -35,6 +35,7 @@
 from airflow.serialization.serialized_objects import DagDependency, SerializedDAG
 from airflow.settings import COMPRESS_SERIALIZED_DAGS, MIN_SERIALIZED_DAG_UPDATE_INTERVAL, json
 from airflow.utils import timezone
+from airflow.utils.serialization import serialize

Review Comment:
   Can we avoid adding new things in to utils namespace? It's already a "dumping ground"
   
   How about
   
   
   ```suggestion
   from airflow.serialization import serialize
   ```
   
   instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org