You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/25 14:06:41 UTC

[GitHub] [hudi] KnightChess opened a new pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

KnightChess opened a new pull request #5134:
URL: https://github.com/apache/hudi/pull/5134


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   fix npc when spark read table which is init by flink.
   
   configuration **hoodie.datasource.write.partitionpath.field (unpartitioned table)** will not write into hoodie.properties
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1079409464


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1082579039


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540",
       "triggerID" : "1082577665",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1079064990


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1082576382


   @KnightChess  i also find this problem， in our product env
   Thank you very much for your fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #5134: [HUDI-3750] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
yihua merged pull request #5134:
URL: https://github.com/apache/hudi/pull/5134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1079064990


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1079409464


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] KnightChess commented on pull request #5134: [HUDI-3750] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
KnightChess commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1084153004


   @yihua ok, thanks :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1079068028


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1082579039


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540",
       "triggerID" : "1082577665",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1082693477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371",
       "triggerID" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a699c9dec9db71622933ad3ef298aa0ba114374b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540",
       "triggerID" : "1082577665",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * a699c9dec9db71622933ad3ef298aa0ba114374b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7371) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7540) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #5134: [HUDI-3750] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1083995326


   @KnightChess Thanks for the fix!  Given that the PR fixes a bug, it should not be a MINOR PR.  I assigned a Jira ticket, HUDI-3750, so we can track this in the release.  Next time, you should create a ticket as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #5134: [MINOR] Fix NPE when build HoodieFileIndex

Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #5134:
URL: https://github.com/apache/hudi/pull/5134#issuecomment-1082577665


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org