You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 03:28:07 UTC

[GitHub] [skywalking] mrproliu commented on a change in pull request #4587: OAP Core polish, especially storage level

mrproliu commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399908578
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
 ##########
 @@ -55,5 +55,12 @@
     /**
      * The column is just saved, never used in query.
      */
-    boolean content() default false;
+    boolean storageOnly() default false;
 
 Review comment:
   I suggest the storageOnly default is `true` in the Column annotation? Because I think most of the columns are just for storage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services