You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "devi-pathak2263 (via GitHub)" <gi...@apache.org> on 2026/03/15 12:21:06 UTC
[PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
devi-pathak2263 opened a new pull request, #5624:
URL: https://github.com/apache/fineract/pull/5624
## Description
This PR adds unit tests for the `StreamUtil` utility class in `fineract-core`.
The following methods are covered:
* `foldLeft` collector functionality
* `mergeMapsOfLists` collector functionality
These tests verify that:
* `foldLeft` correctly reduces a stream using the provided accumulator.
* `mergeMapsOfLists` correctly merges maps with list values by concatenating lists for identical keys.
This improves test coverage and ensures the correctness of commonly used utility collectors.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2534
##Testing
Executed locally:
./gradlew spotlessApply
./gradlew :fineract-core
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
* [x] Write the commit message as per [[our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
* [x] Acknowledge that we will not review PRs that are not passing the build *("green")* - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
* [x] Create/update [[unit or integration tests](https://fineract.apache.org/docs/current/#_testing)](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
* [x] Follow our [[coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions)](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
* [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
* [x] [[This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit)](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [[developer mailing list](https://fineract.apache.org/#contribute)](https://fineract.apache.org/#contribute).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
Posted by "devi-pathak2263 (via GitHub)" <gi...@apache.org>.
devi-pathak2263 commented on PR #5624:
URL: https://github.com/apache/fineract/pull/5624#issuecomment-4074303452
> @devi-pathak2263 Can you please:
>
> * Set the commit email address to match with your github account email address?
> * Set GPG signature for commit?
I have now:
- updated the commit author email to match my GitHub account
- amended the commit with a GPG signature
The latest commit should now be verified. Let me know if anything else needs improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5624:
URL: https://github.com/apache/fineract/pull/5624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5624:
URL: https://github.com/apache/fineract/pull/5624#issuecomment-4073509989
@devi-pathak2263 Can you please:
- Set the commit email address to match with your github account email address?
- Set GPG signature for commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5624:
URL: https://github.com/apache/fineract/pull/5624#issuecomment-4067547826
@devi-pathak2263 Please squash your commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2534: Add unit tests for StreamUtil utility class [fineract]
Posted by "devi-pathak2263 (via GitHub)" <gi...@apache.org>.
devi-pathak2263 commented on PR #5624:
URL: https://github.com/apache/fineract/pull/5624#issuecomment-4068560935
> @devi-pathak2263 Please squash your commits.
Thanks for the feedback. I have squashed the commits into a single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org