You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2010/09/07 09:32:34 UTC
svn commit: r993258 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c
Author: rhuijben
Date: Tue Sep 7 07:32:34 2010
New Revision: 993258
URL: http://svn.apache.org/viewvc?rev=993258&view=rev
Log:
* subversion/mod_dav_svn/reports/log.c
(dav_svn__log_report): Partially revert r993246 to fix compilation.
The malformed_element_error() function is not defined nor a public
api.
Modified:
subversion/trunk/subversion/mod_dav_svn/reports/log.c
Modified: subversion/trunk/subversion/mod_dav_svn/reports/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/reports/log.c?rev=993258&r1=993257&r2=993258&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/reports/log.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/reports/log.c Tue Sep 7 07:32:34 2010
@@ -311,15 +311,7 @@ dav_svn__log_report(const dav_resource *
else if (strcmp(child->name, "end-revision") == 0)
end = SVN_STR_TO_REV(dav_xml_get_cdata(child, resource->pool, 1));
else if (strcmp(child->name, "limit") == 0)
- {
- serr = svn_cstring_atoi(&limit,
- dav_xml_get_cdata(child, resource->pool, 1));
- if (serr)
- {
- svn_error_clear(serr);
- return malformed_element_error("limit", resource->pool);
- }
- }
+ limit = atoi(dav_xml_get_cdata(child, resource->pool, 1));
else if (strcmp(child->name, "discover-changed-paths") == 0)
discover_changed_paths = TRUE; /* presence indicates positivity */
else if (strcmp(child->name, "strict-node-history") == 0)
Re: svn commit: r993258 -
/subversion/trunk/subversion/mod_dav_svn/reports/log.c
Posted by Stefan Sperling <st...@elego.de>.
On Tue, Sep 07, 2010 at 01:19:42PM +0530, Senthil Kumaran S wrote:
> Hi Bert,
>
> rhuijben@apache.org wrote:
> >Author: rhuijben
> >Date: Tue Sep 7 07:32:34 2010
> >New Revision: 993258
> >
> >URL: http://svn.apache.org/viewvc?rev=993258&view=rev
> >Log:
> >* subversion/mod_dav_svn/reports/log.c
> > (dav_svn__log_report): Partially revert r993246 to fix compilation.
> > The malformed_element_error() function is not defined nor a public
> > api.
>
> I was about to commit the attached patch in order to fix this, but I
> saw your commit before that. Since malformed_element_error() is used
> in many files I think we make this subversion private.
See r993310, which reports the error in a way that is in line with the error
handling elsewhere in dav_svn__log_report(). Note that there is a goto
statement involved, so we may not be able to re-use the
malformed_element_error() function after all.
Thanks,
Stefan
Re: svn commit: r993258 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c
Posted by Senthil Kumaran S <se...@collab.net>.
Hi Bert,
rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Tue Sep 7 07:32:34 2010
> New Revision: 993258
>
> URL: http://svn.apache.org/viewvc?rev=993258&view=rev
> Log:
> * subversion/mod_dav_svn/reports/log.c
> (dav_svn__log_report): Partially revert r993246 to fix compilation.
> The malformed_element_error() function is not defined nor a public
> api.
I was about to commit the attached patch in order to fix this, but I saw your
commit before that. Since malformed_element_error() is used in many files I
think we make this subversion private.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/