You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 09:22:04 UTC
[GitHub] [airflow] turbaszek opened a new pull request #11326: Fix interpolation issue in conf_vars in tests
turbaszek opened a new pull request #11326:
URL: https://github.com/apache/airflow/pull/11326
It seems that using conf_vars for strings with interpolation
breaks config parser because proper string is replaced by already
interpolated string. This fix errors from v1-10-test
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #11326: Fix interpolation issue in conf_vars in tests
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #11326:
URL: https://github.com/apache/airflow/pull/11326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11326: Fix interpolation issue in conf_vars in tests
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11326:
URL: https://github.com/apache/airflow/pull/11326#issuecomment-704810030
I was able to replicate error from:
https://github.com/apache/airflow/runs/1213562513
by running `pytest -s tests/upgrade/ tests/utils/test_dag_processing.py`. Before this fix I see:
```
backports.configparser.InterpolationMissingOptionError: Bad value substitution: option 'simple_log_format' in section 'core' contains an interpolation key 'asctime' which is not a valid option name. Raw value: '%(asctime)s %(levelname)s - %(message)s'
```
Other failing tests fail probably due to side effects that were not created by tests that failed...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org