You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/09 15:01:55 UTC
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#5727: [AIRFLOW-5114] Fix gcp_transfer_hook behavior with default operator
arguments
nuclearpinguin commented on a change in pull request #5727: [AIRFLOW-5114] Fix gcp_transfer_hook behavior with default operator arguments
URL: https://github.com/apache/airflow/pull/5727#discussion_r312517629
##########
File path: airflow/contrib/hooks/gcp_transfer_hook.py
##########
@@ -370,7 +372,7 @@ def wait_for_transfer_job(
self,
job: Dict,
expected_statuses: Tuple[str] = (GcpTransferOperationStatus.SUCCESS,),
- timeout: int = 60
+ timeout: Union[numbers.Real, timedelta, None] = None
Review comment:
```suggestion
timeout: Optional[Union[numbers.Real, timedelta]] = None
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services