You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/04/18 23:12:16 UTC

[PR] chore(stream): remove internal FanOut Unzip [pekko]

He-Pin opened a new pull request, #2873:
URL: https://github.com/apache/pekko/pull/2873

   ## Summary
   This is the first small slice for #2860.
   
   It removes the dead internal `org.apache.pekko.stream.impl.Unzip` implementation from `FanOut.scala` and adds the matching `2.0.x` MiMa exclusions for the deleted binary-visible symbols.
   
   The public Scala/Java DSL `Unzip` is already GraphStage-based, so this PR only drops the stale internal actor-backed implementation. This cleanup is part of Apache Pekko, which is now Apache licensed.
   
   ## Motivation
   - make #2860 progress in the smallest safe step
   - remove verified dead internal legacy code before larger runtime migrations
   - keep the cleanup independently reviewable and independently releasable
   
   ## Modification
   - delete the internal `impl.Unzip` object/class from `stream/src/main/scala/org/apache/pekko/stream/impl/FanOut.scala`
   - add `stream/src/main/mima-filters/2.0.x.backwards.excludes/remove-internal-unzip.excludes`
   
   ## Result
   - the dead internal Unzip path is removed
   - public `Unzip` behavior remains unchanged
   - this slice stands on its own as a tiny cleanup PR before the larger fanout/TLS work
   
   ## Validation
   - `sbt scalafmtAll`
   - `sbt "stream/test:compile"`
   - `sbt "stream/mimaReportBinaryIssues"`
   - `sbt "stream-tests/testOnly org.apache.pekko.stream.scaladsl.GraphUnzipSpec"`
   
   ## Upstream / references
   - Issue: https://github.com/apache/pekko/issues/2860
   - No single upstream Akka commit maps 1:1 to this cleanup slice; this PR is derived from the current Pekko codebase inventory and issue-driven migration plan.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore(stream): remove internal FanOut Unzip [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #2873:
URL: https://github.com/apache/pekko/pull/2873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org