[GitHub] [iceberg] kbendick commented on a change in pull request #3035: AWS: update DynamoDbCatalog.dropNamespace attr check

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3035:
URL: https://github.com/apache/iceberg/pull/3035#discussion_r698874451



##########
File path: aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java
##########
@@ -248,7 +248,7 @@ public boolean dropNamespace(Namespace namespace) throws NamespaceNotEmptyExcept
       dynamo.deleteItem(DeleteItemRequest.builder()
           .tableName(awsProperties.dynamoDbTableName())
           .key(namespacePrimaryKey(namespace))
-          .conditionExpression("attribute_exists(" + namespace + ")")
+          .conditionExpression("attribute_exists(" + DynamoDbCatalog.COL_NAMESPACE + ")")

Review comment:
       Is this `conditionExpression` even needed? Are there any records that don't have a key `namespace` in them?
   
   I guess if users are adding their own metadata to records or have a projected view (GSI)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org