You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/04 10:36:03 UTC
[GitHub] [incubator-doris] lingbin commented on a change in pull request
#2831: Refactor `AgentServer` to make it less error-prone and more readable
lingbin commented on a change in pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable
URL: https://github.com/apache/incubator-doris/pull/2831#discussion_r374593077
##########
File path: be/src/service/doris_main.cpp
##########
@@ -50,6 +50,7 @@
#include "agent/topic_subscriber.h"
#include "util/doris_metrics.h"
#include "olap/options.h"
+#include "olap/storage_engine.h"
Review comment:
Yes. `StorageEngine` is used in this file.
Previously, because of some unneeded header file included in `agent_server.h` will include `storage_engine.h`, these unneeded header files were removed from `agent_server.h`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org