You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Tamas Jambor <ja...@gmail.com> on 2010/06/28 00:41:58 UTC
bug in FileDataModel
hi Sean,
I might have spotted a bug in FileDataModel, in line 444, you create a
PreferenceArray newPrefs and then shift the existing values one step
down, but in the end this updated object never gets written back to the
main data object.
Tamas
Re: bug in FileDataModel
Posted by Sean Owen <sr...@gmail.com>.
Could be missing something but I don't follow. It is indeed loading
new data, but, there may already be preferences from that user in the
new data at this point. These are the cases being handled here.
On Mon, Jun 28, 2010 at 9:23 PM, Tamas Jambor <ja...@gmail.com> wrote:
> one more thing I noticed. from line 457-484, the whole stuff could be
> removed, since you are working with fresh data, so those situations don't
> really apply, I think
>
Re: bug in FileDataModel
Posted by Tamas Jambor <ja...@gmail.com>.
one more thing I noticed. from line 457-484, the whole stuff could be
removed, since you are working with fresh data, so those situations don't
really apply, I think
On Mon, Jun 28, 2010 at 8:23 PM, Sean Owen <sr...@gmail.com> wrote:
> Yah good one, that looks wrong. I will fix that now (and I think a
> similar problem later in the file.)
>
> On Sun, Jun 27, 2010 at 11:41 PM, Tamas Jambor <ja...@gmail.com> wrote:
> > hi Sean,
> >
> > I might have spotted a bug in FileDataModel, in line 444, you create a
> > PreferenceArray newPrefs and then shift the existing values one step
> down,
> > but in the end this updated object never gets written back to the main
> data
> > object.
> >
> > Tamas
> >
>
Re: bug in FileDataModel
Posted by Sean Owen <sr...@gmail.com>.
Yah good one, that looks wrong. I will fix that now (and I think a
similar problem later in the file.)
On Sun, Jun 27, 2010 at 11:41 PM, Tamas Jambor <ja...@gmail.com> wrote:
> hi Sean,
>
> I might have spotted a bug in FileDataModel, in line 444, you create a
> PreferenceArray newPrefs and then shift the existing values one step down,
> but in the end this updated object never gets written back to the main data
> object.
>
> Tamas
>