You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2022/12/02 14:58:52 UTC
[myfaces-tobago] branch t5_selectMany updated (713ebb95e1 -> abbe4f273c)
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a change to branch t5_selectMany
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
from 713ebb95e1 rename controller
new f37bfa5ba6 feat(selectManyList): preliminary
new abbe4f273c feat(selectManyList): handle filter null
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../tobago/internal/renderkit/renderer/SelectManyListRenderer.java | 2 +-
.../internal/taglib/component/SelectManyListTagDeclaration.java | 2 ++
.../tobago-theme-standard/src/main/ts/tobago-select-many-list.ts | 4 ++--
3 files changed, 5 insertions(+), 3 deletions(-)
[myfaces-tobago] 02/02: feat(selectManyList): handle filter null
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch t5_selectMany
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit abbe4f273cc8e13a31bf96662d7d961f8fc893c5
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Fri Dec 2 15:58:27 2022 +0100
feat(selectManyList): handle filter null
Issue: TOBAGO-2159
---
.../tobago/internal/renderkit/renderer/SelectManyListRenderer.java | 2 +-
.../tobago-theme-standard/src/main/ts/tobago-select-many-list.ts | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListRenderer.java
index ee5234a993..d6ebee277d 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListRenderer.java
@@ -143,7 +143,7 @@ public class SelectManyListRenderer<T extends AbstractUISelectManyList> extends
writer.writeIdAttribute(filterId);
writer.writeClassAttribute(TobagoClass.FILTER, BootstrapClass.FORM_CONTROL);
writer.writeAttribute(HtmlAttributes.AUTOCOMPLETE, "off", false);
- writer.writeAttribute(HtmlAttributes.READONLY, filter == null);
+ writer.writeAttribute(HtmlAttributes.READONLY, filter == null || filter.isEmpty());
writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
renderFocus(clientId, component.isFocus(), component.isError(), facesContext, writer);
diff --git a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many-list.ts b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many-list.ts
index da5eec2dfc..fdc7a4cae5 100644
--- a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many-list.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many-list.ts
@@ -105,7 +105,7 @@ class SelectManyList extends HTMLElement {
this.initList();
// init filter
- if (this.filter != null) {
+ if (this.filter) {
const input = this.filterInput;
input.addEventListener("keyup", this.filterEvent.bind(this));
}
@@ -178,7 +178,7 @@ class SelectManyList extends HTMLElement {
row.classList.remove(this.CssClass.TABLE_PRIMARY);
}
- if (!this.classList.contains(this.CssClass.TOBAGO_DISABLED) && this.filter === null) {
+ if (!this.classList.contains(this.CssClass.TOBAGO_DISABLED) && !this.filter) {
// disable input field to prevent focus.
if (this.badgeCloseButtons.length > 0 && this.filterInput.id === document.activeElement.id) {
this.badgeCloseButtons.item(this.badgeCloseButtons.length - 1).focus();
[myfaces-tobago] 01/02: feat(selectManyList): preliminary
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch t5_selectMany
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit f37bfa5ba66fab2899358ec4ed9d48e4483ae801
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Fri Dec 2 15:41:39 2022 +0100
feat(selectManyList): preliminary
Issue: TOBAGO-2159
---
.../tobago/internal/taglib/component/SelectManyListTagDeclaration.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyListTagDeclaration.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyListTagDeclaration.java
index 88efbd3bcd..e7572d504b 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyListTagDeclaration.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyListTagDeclaration.java
@@ -20,6 +20,7 @@
package org.apache.myfaces.tobago.internal.taglib.component;
import org.apache.myfaces.tobago.apt.annotation.Behavior;
+import org.apache.myfaces.tobago.apt.annotation.Preliminary;
import org.apache.myfaces.tobago.apt.annotation.Tag;
import org.apache.myfaces.tobago.apt.annotation.TagAttribute;
import org.apache.myfaces.tobago.apt.annotation.UIComponentTag;
@@ -54,6 +55,7 @@ import javax.faces.component.UISelectMany;
/**
* Render a multi selection option listbox.
*/
+@Preliminary
@Tag(name = "selectManyList")
@UIComponentTag(
uiComponent = "org.apache.myfaces.tobago.component.UISelectManyList",