[PATCH] New redirect

[Vincenzo Gianferrari Pini <vi...@praxis.it>]

Noel,

I'm continuing to add fixes incrementally (now added #6):

1) The sender domain check now is optional, controlled by <fakeDomainCheck>, that defaults to true.

2) Some "getX()" values where hardcoded in AbstractNotify; now they are controlled by init parameters that default to the previous values. The parameters involved are: <prefix>, <inline>, <attachment> and <passThrough>.

3) In AbstractNotify (and subclasses) <message> and <attachError> can be used instead of <notice> and <attachStackTrace>.

4) Javadoc changed accordingly plus a few fixes.

5) AbstractRedirect and all the subclasses where causing a "null pointer exception" to be thrown deep in AvalonMailRepository, very hard to understand, because newName(MailImpl) was building a too long name if a "configuration loop" was happening.

6) Setting <debug>true</debug> in any mailet subclass of AbstractRedirect was causing a "null pointer exception" to be thrown during initialization under certain circumstances.

The change #2 above allows to add in config.xml something like:

        <!-- Check attachment extensions for possible viruses -->
         <mailet match="AttachmentFileNameIs=*.exe,*.com,*.bat,*.pif,*.scr,*.vbs,*.eml,*.avi,*.mp3,*.mpeg,*.shs" class="Bounce">
            <inline>heads</inline>
            <attachment>none</attachment>
            <passThrough>false</passThrough>
            <prefix>[REJECTED]</prefix>
            <message>
The Security Policy of ACME Corp. does not allow to forward messages containing attachments having any of the extensions .exe, .com, .bat, .pif, .scr, .vbs, .eml, .avi, .mp3, .mpeg, .shs, therefore such messages are rejected. Please don't reply to this e-mail as it has been automatically sent by the antivirus system.

Regards, Postmaster acme.com
-----------------------------
            </message>
         </mailet>

The <attachment>none</attachment> was not allowed before in Bounce, and the default was "message", and in such a case, if the message had an infected attachment, it would have been bounced back to the (possibly fake) sender together with the virus.




When you have time, could you apply it, as I will not be around the next weekend.

Vincenzo


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org