You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/06/19 11:52:03 UTC
[GitHub] [spark] itholic commented on a diff in pull request #41660: [SPARK-43624][PS][CONNECT] Add `EWM` to SparkConnectPlanner.
itholic commented on code in PR #41660:
URL: https://github.com/apache/spark/pull/41660#discussion_r1233948214
##########
python/pyspark/pandas/tests/connect/test_parity_ewm.py:
##########
@@ -22,11 +22,15 @@
class EWMParityTests(EWMTestsMixin, PandasOnSparkTestUtils, ReusedConnectTestCase, TestUtils):
- @unittest.skip("TODO(SPARK-43624): Enable ExponentialMovingLike.mean with Spark Connect.")
+ @unittest.skip(
+ "TODO(SPARK-43611): Fix unexpected `AnalysisException` from Spark Connect client."
+ )
Review Comment:
Before this fix, this test was JVM-dependent, but now it is generating the same error as the unexpected `AnalysisException` posted in SPARK-43611. Will address the related tickets collectively in SPARK-43611 at once.
##########
python/pyspark/pandas/tests/connect/test_parity_ewm.py:
##########
@@ -22,11 +22,15 @@
class EWMParityTests(EWMTestsMixin, PandasOnSparkTestUtils, ReusedConnectTestCase, TestUtils):
- @unittest.skip("TODO(SPARK-43624): Enable ExponentialMovingLike.mean with Spark Connect.")
+ @unittest.skip(
+ "TODO(SPARK-43611): Fix unexpected `AnalysisException` from Spark Connect client."
+ )
Review Comment:
Before this fix, this test was JVM-dependent, but now it is generating the same error as the unexpected `AnalysisException` posted in SPARK-43611. Will address the related tickets collectively in SPARK-43611 at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org