You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/08/28 21:43:13 UTC

[GitHub] [madlib] hpandeycodeit commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA

hpandeycodeit commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#issuecomment-525934485
 
 
   > @hpandeycodeit
   > I haven't reviewed the code yet but looks like there aren't any tests for this PR. Can you add tests for all possible scenarios related to the changes made in this PR ?
   > Make sure to test for all possible test cases for `evaluate_every` and `perplexity`
   
   @kaknikhil I will add the tests cases soon to the PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services