You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/18 00:53:00 UTC
[jira] [Commented] (SAMZA-1880) Rename non-metrics classes which
use "Timer" in their name
[ https://issues.apache.org/jira/browse/SAMZA-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618345#comment-16618345 ]
ASF GitHub Bot commented on SAMZA-1880:
---------------------------------------
GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/644
SAMZA-1880: Rename non-metrics classes which use Timer in their name
Summary of API changes:
1. TimerRegistry -> KeyScheduler; _register_ -> _schedule_
2. TimerFunction -> SchedulingFunction; _registerTimer_ -> _schedulingInit_, _onTimer_ -> _executeForKey_
3. TimerCallback -> SchedulingCallback _onTimer_ -> _execute_
4. TaskContext: _registerTimer_ -> _scheduleCallback_, _deleteTimer_ -> _deleteScheduledCallback_
Only terminology changes are intended (e.g. classes, var names, logs). No functionality change is intended.
An upcoming PR will further update TaskContext and the access to the scheduling logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza rename_timer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #644
----
commit 67c3608d00fb70aa7124c0c671ba281e4dbc5a57
Author: Cameron Lee <ca...@...>
Date: 2018-09-18T00:25:18Z
SAMZA-1880: Rename non-metrics classes which use Timer in their name
commit db4fad6debe101f5103537f7c942011505ea2829
Author: Cameron Lee <ca...@...>
Date: 2018-09-18T00:46:18Z
minor style check update
----
> Rename non-metrics classes which use "Timer" in their name
> ----------------------------------------------------------
>
> Key: SAMZA-1880
> URL: https://issues.apache.org/jira/browse/SAMZA-1880
> Project: Samza
> Issue Type: Improvement
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
>
> Currently, the term "timer" is overloaded. It is used as both a metrics term and as a scheduling term. We can change the usage of "timer" in the scheduling context so that there is less naming conflict.
> This will be done as a prerequisite to SAMZA-1714 in order to clarify the scheduling component of the task context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)